cc/tiles/tile_manager_perftest.cc - Issue 1174733003: cc, gpu: Use RGBA when using msaa on systems that don't support BGRA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/tiles/tile_manager_perftest.cc

Issue 1174733003: cc, gpu: Use RGBA when using msaa on systems that don't support BGRA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/tiles/tile_manager_perftest.cc

diff --git a/cc/tiles/tile_manager_perftest.cc b/cc/tiles/tile_manager_perftest.cc

index 5fdecd2e2e5240136229bdf08757a183feb58793..d9b340d650ef7995b084923dd3c55993f3f7b0ec 100644

--- a/cc/tiles/tile_manager_perftest.cc

+++ b/cc/tiles/tile_manager_perftest.cc

@@ -64,8 +64,9 @@ class FakeTileTaskRunnerImpl : public TileTaskRunner, public TileTaskClient {

}

completed_tasks_.clear();

}

- ResourceFormat GetResourceFormat() override {

- return RGBA_8888;

+ ResourceFormat GetResourceFormat() const override { return RGBA_8888; }

+ bool GetResourceRequiresSwizzle() const override {

+ return !PlatformColor::SameComponentOrder(GetResourceFormat());

}

// Overridden from TileTaskClient:

« no previous file with comments | « cc/tiles/tile_manager.cc ('k') | gpu/command_buffer/common/capabilities.h » ('j') | no next file with comments »