Issue 11747014: Translate infobar delegate: name the "type_" and "error_" fields "infobar_type_" and "error_type_" …

Issue 11747014: Translate infobar delegate: name the "type_" and "error_" fields "infobar_type_" and "error_type_" … (Closed)

Created:
7 years, 11 months ago by Peter Kasting

Modified:
7 years, 11 months ago

Reviewers:
Elliot Glaysher, sky

CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Translate infobar delegate: name the "type_" and "error_" fields "infobar_type_" and "error_type_" for clarity and to match the underlying type names. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175349

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -60 lines)			Patch
M	chrome/browser/autofill/autofill_browsertest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/policy/policy_browsertest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/translate/translate_infobar_delegate.h	View		4 chunks	+6 lines, -6 lines	2 comments	Download
M	chrome/browser/translate/translate_infobar_delegate.cc	View		7 chunks	+25 lines, -24 lines	0 comments	Download
M	chrome/browser/translate/translate_manager_browsertest.cc	View		15 chunks	+27 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm	View	1	5 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/infobars/translate_infobar_base.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/11747014/diff/10/chrome/browser/translate/translate_infobar_delegate.h File chrome/browser/translate/translate_infobar_delegate.h (right): https://codereview.chromium.org/11747014/diff/10/chrome/browser/translate/translate_infobar_delegate.h#newcode175 chrome/browser/translate/translate_infobar_delegate.h:175: Type infobar_type_; style guide says no protected members.

7 years, 11 months ago (2013-01-07 16:44:50 UTC) #2

Peter Kasting

7 years, 11 months ago (2013-01-07 16:55:06 UTC) #3

https://codereview.chromium.org/11747014/diff/10/chrome/browser/translate/tra...
File chrome/browser/translate/translate_infobar_delegate.h (right):

https://codereview.chromium.org/11747014/diff/10/chrome/browser/translate/tra...
chrome/browser/translate/translate_infobar_delegate.h:175: Type infobar_type_;
On 2013/01/07 16:44:50, sky wrote:
> style guide says no protected members.

Yep, I'm fixing this in a separate change.

Expand Messages | Collapse Messages