Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Issue 1174693002: PPC64: Adjust simulator stack safety margin. (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC64: Adjust simulator stack safety margin. This fixes a failure in test/mjsunit/regress/regress-crbug-491062.js. R=dstence@us.ibm.com, michael_dawson@ca.ibm.com, svenpanne@chromium.org BUG= Committed: https://crrev.com/440a1c7a36f7f3d82a3e5c648691c6a3f9780329 Cr-Commit-Position: refs/heads/master@{#28924}

Patch Set 1 #

Patch Set 2 : Keep 32-bit simulator stack size at 1MB. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/simulator-ppc.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-09 19:16:29 UTC) #1
dstence
lgtm
5 years, 6 months ago (2015-06-09 19:27:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174693002/1
5 years, 6 months ago (2015-06-09 19:29:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3271)
5 years, 6 months ago (2015-06-09 19:32:09 UTC) #6
dstence
lgtm
5 years, 6 months ago (2015-06-10 13:24:43 UTC) #8
MTBrandyberry
Still need approval from Sven for the flag-definitions.h change.
5 years, 6 months ago (2015-06-10 15:53:09 UTC) #9
Sven Panne
lgtm
5 years, 6 months ago (2015-06-11 06:41:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174693002/20001
5 years, 6 months ago (2015-06-11 06:42:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-11 07:07:43 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 07:08:02 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/440a1c7a36f7f3d82a3e5c648691c6a3f9780329
Cr-Commit-Position: refs/heads/master@{#28924}

Powered by Google App Engine
This is Rietveld 408576698