Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1174683003: Resurrect deploy_sdk and make it use prepare_pub_packages.py (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
Cutch, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Resurrect deploy_sdk and make it use prepare_pub_packages.py Works like a charm, and is now much simpler thanks to John's work. R=abarth@chromium.org, johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/22c0500080a62c9d81a80d6a6c0546a3823bb997

Patch Set 1 #

Patch Set 2 : Remove unsued --extra-mojom-dir arg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -0 lines) Patch
A sky/tools/deploy_sdk.py View 1 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
5 years, 6 months ago (2015-06-09 20:12:44 UTC) #1
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-09 20:18:40 UTC) #3
eseidel
5 years, 6 months ago (2015-06-09 20:19:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
22c0500080a62c9d81a80d6a6c0546a3823bb997 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698