Issue 1174683002: [Android] Add check_return=True to Forwarder init & kill.

Issue 1174683002: [Android] Add check_return=True to Forwarder init & kill. (Closed)

Created:
5 years, 6 months ago by jbudorick

Modified:
5 years, 6 months ago

Reviewers:
sullivan, perezju

CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Android] Add check_return=True to Forwarder init & kill. BUG=489317 Committed: https://crrev.com/d4d512e93e517c85583b82394b37a6dcdcdbdf71 Cr-Commit-Position: refs/heads/master@{#333594}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	build/android/pylib/forwarder.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

jbudorick

We were raising exceptions in these scenarios prior to https://codereview.chromium.org/1092703002, when I neglected to add ...

5 years, 6 months ago (2015-06-09 18:45:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174683002/1

5 years, 6 months ago (2015-06-09 20:43:11 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-09 22:21:53 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d4d512e93e517c85583b82394b37a6dcdcdbdf71
Cr-Commit-Position: refs/heads/master@{#333594}