Show progress bar during scanning.

WIP: Show progress bar during scanning.

BUG=475182
Committed: https://crrev.com/f84c62613ac15c2d1672c8298691c448005d35a0
Cr-Commit-Position: refs/heads/master@{#333779}

[Steve McKay, 2015-06-09 22:02:14]

Patchset #1 (id:1) has been deleted

[Steve McKay, 2015-06-09 22:02:24]

Patchset #1 (id:20001) has been deleted

[Steve McKay, 2015-06-09 22:10:27]

smckay@chromium.org changed reviewers:
+ fukino@chromium.org, mtomasz@chromium.org

[Steve McKay, 2015-06-09 22:10:27]

Notes:

The new code is not hand tested yet (see reason below). There is new unit test
coverage for scan progress calculation.

Cloud Backup is broken when running hosted ChromeOS on my Linux backup (there
are a number of console errors, that look unrelated).

I have not been able to successfully build for a development device, as gclient
runhooks is failing with some errors emanating from
generate_gles2_embedded_data.py.

Sighs all around.

I'll take another swing at getting a dev device build working tomorrow to see if
things are working there.

[Steve McKay, 2015-06-09 23:34:32]

Patchset #1 (id:40001) has been deleted

[Steve McKay, 2015-06-09 23:38:45]

Okay. Looks like I don't have the right keys or whateva when running hosted on
my Linux desktop. That explains the breakage. I did a little hacking around that
and was able to hand-test the progress bar.

After testing I reduced the transition time to .1s, as on *very fast* scans a
user won't see any progress at all. So there's a knob we can dial, longer
transition == more pretty, shorter, or none, equals more accurate and
responsive.

I'll send out a screen cast shortly for those wishing to see the pixels.

[fukino, 2015-06-10 05:40:07]

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
File ui/file_manager/file_manager/background/js/media_scanner.js (right):

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/media_scanner.js:673: // we wan to
ensure progress never exceeds 100.
nit: wan -> want

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/media_scanner.js:676: progress ==
100;
== -> =

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/main.html:293: <div class="progress"><div
class="value"></div></div>
optional nit: Alternatively, we can use <paper-progress> here.

[Steve McKay, 2015-06-10 05:54:36]

PTAL.

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
File ui/file_manager/file_manager/background/js/media_scanner.js (right):

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/media_scanner.js:673: // we wan to
ensure progress never exceeds 100.
On 2015/06/10 05:40:07, fukino wrote:
> nit: wan -> want

Done.

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/media_scanner.js:676: progress ==
100;
On 2015/06/10 05:40:07, fukino wrote:
> == -> =

Done.

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/main.html:293: <div class="progress"><div
class="value"></div></div>
On 2015/06/10 05:40:07, fukino wrote:
> optional nit: Alternatively, we can use <paper-progress> here.

Happy to do that, but I don't know how. Polymer is still weird to me.
Would you be willing to make that update...I assume it would be quick for you.

[fukino, 2015-06-10 06:31:52]

LGTM.

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
ui/file_manager/file_manager/main.html:293: <div class="progress"><div
class="value"></div></div>
On 2015/06/10 05:54:36, Steve McKay wrote:
> On 2015/06/10 05:40:07, fukino wrote:
> > optional nit: Alternatively, we can use <paper-progress> here.
> 
> Happy to do that, but I don't know how. Polymer is still weird to me.
> Would you be willing to make that update...I assume it would be quick for you.

The current implementation looks almost same as Polymer's one, so I think
current implementation is absolutely OK.
And, yes, I'll make that update later for consistency in implementation (in low
priority).

[Steve McKay, 2015-06-10 19:30:33]

On 2015/06/10 06:31:52, fukino wrote:
> LGTM.
> 
>
https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
> File ui/file_manager/file_manager/main.html (right):
> 
>
https://codereview.chromium.org/1174653002/diff/100001/ui/file_manager/file_m...
> ui/file_manager/file_manager/main.html:293: <div class="progress"><div
> class="value"></div></div>
> On 2015/06/10 05:54:36, Steve McKay wrote:
> > On 2015/06/10 05:40:07, fukino wrote:
> > > optional nit: Alternatively, we can use <paper-progress> here.
> > 
> > Happy to do that, but I don't know how. Polymer is still weird to me.
> > Would you be willing to make that update...I assume it would be quick for
you.
> 
> The current implementation looks almost same as Polymer's one, so I think
> current implementation is absolutely OK.
> And, yes, I'll make that update later for consistency in implementation (in
low
> priority).

Sounds good. I updated the css so that the new progress bar matches the progress
center progress bars. So there's no pressing need for you to make the update.

[Steve McKay, 2015-06-10 19:33:22]

Normalize statics object naming.

[Steve McKay, 2015-06-10 19:35:16]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-06-10 19:35:17]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/1174653002/#ps160001
(title: "Normalize statics object naming.")

[commit-bot: I haz the power, 2015-06-10 19:35:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174653002/160001

[commit-bot: I haz the power, 2015-06-10 20:04:02]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2015-06-10 20:04:57]

Patchset 6 (id:??) landed as
https://crrev.com/f84c62613ac15c2d1672c8298691c448005d35a0
Cr-Commit-Position: refs/heads/master@{#333779}

[Dan Beam, 2015-06-10 20:37:30]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-06-10 20:37:30]

https://codereview.chromium.org/1174653002/diff/160001/ui/file_manager/file_m...
File ui/file_manager/file_manager/background/js/media_scanner.js (right):

https://codereview.chromium.org/1174653002/diff/160001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/media_scanner.js:426: *   }
,