expose strong checker API, for use by analyzer_cli

lib/src/report.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Summarizes the information produced by the checker.
 library dev_compiler.src.report;
 
 import 'dart:math' show max;
 
 import 'package:analyzer/src/generated/ast.dart' show AstNode, CompilationUnit;
@@ skipping 24 matching lines @@
   final int begin;
 
   /// Offset where the error message ends in the tracked source file.
   final int end;
 
   const Message(this.message, this.level, this.begin, this.end);
 }
 
 // Interface used to report error messages from the checker.
 abstract class CheckerReporter {
+  void log(Message message);
+}
+
+// Interface used to report error messages from the compiler.
+abstract class CompilerReporter extends CheckerReporter {
   final AnalysisContext _context;
   CompilationUnit _unit;
   Source _unitSource;
 
-  CheckerReporter(this._context);
+  CompilerReporter(this._context);
 
   /// Called when starting to process a library.
   void enterLibrary(Uri uri);
   void leaveLibrary();
 
   /// Called when starting to process an HTML source file.
   void enterHtml(Uri uri);
   void leaveHtml();
 
   /// Called when starting to process a source. All subsequent log entries must
   /// belong to this source until the next call to enterSource.
   void enterCompilationUnit(CompilationUnit unit, [Source source]) {
     _unit = unit;
     _unitSource = source;
   }
   void leaveCompilationUnit() {
     _unit = null;
     _unitSource = null;
   }
 
-  void log(Message message);
-
   // Called in server-mode.
   void clearLibrary(Uri uri);
   void clearHtml(Uri uri);
   void clearAll();
 
   SourceSpanWithContext _createSpan(int start, int end) =>
       createSpan(_context, _unit, start, end, _unitSource);
 }
 
 final _checkerLogger = new Logger('dev_compiler.checker');
 
 /// Simple reporter that logs checker messages as they are seen.
-class LogReporter extends CheckerReporter {
+class LogReporter extends CompilerReporter {
   final bool useColors;
   Source _current;
 
   LogReporter(AnalysisContext context, {this.useColors: false})
       : super(context);
 
   void enterLibrary(Uri uri) {}
   void leaveLibrary() {}
 
   void enterHtml(Uri uri) {}
@@ skipping 10 matching lines @@
     final text = '[${message.runtimeType}] ${message.message}';
     _checkerLogger.log(level, span.message(text, color: color));
   }
 
   void clearLibrary(Uri uri) {}
   void clearHtml(Uri uri) {}
   void clearAll() {}
 }
 
 /// A reporter that gathers all the information in a [GlobalSummary].
-class SummaryReporter extends CheckerReporter {
+class SummaryReporter extends CompilerReporter {
   GlobalSummary result = new GlobalSummary();
   IndividualSummary _current;
   final Level _level;
 
   SummaryReporter(AnalysisContext context, [this._level = Level.ALL])
       : super(context);
 
   void enterLibrary(Uri uri) {
     var container;
     if (uri.scheme == 'package') {
@@ skipping 56 matching lines @@
 
 /// Produces a string representation of the summary.
 String summaryToString(GlobalSummary summary) {
   var counter = new _Counter();
   summary.accept(counter);
 
   var table = new _Table();
   // Declare columns and add header
   table.declareColumn('package');
   table.declareColumn('AnalyzerError', abbreviate: true);
-  var activeInfoTypes =
-      infoTypes.where((type) => counter.totals['$type'] != null);
-  activeInfoTypes
-      .forEach((type) => table.declareColumn('$type', abbreviate: true));
+
+  var activeInfoTypes = counter.totals.keys;
+  activeInfoTypes.forEach((t) => table.declareColumn(t, abbreviate: true));
   table.declareColumn('LinesOfCode', abbreviate: true);
   table.addHeader();
 
   // Add entries for each package
   appendCount(count) => table.addEntry(count == null ? 0 : count);
   for (var package in counter.errorCount.keys) {
     appendCount(package);
     appendCount(counter.errorCount[package]['AnalyzerError']);
-    activeInfoTypes
-        .forEach((e) => appendCount(counter.errorCount[package]['$e']));
+    activeInfoTypes.forEach((t) => appendCount(counter.errorCount[package][t]));
     appendCount(counter.linesOfCode[package]);
   }
 
   // Add totals, percents and a new header for quick reference
   table.addEmptyRow();
   table.addHeader();
   table.addEntry('total');
   appendCount(counter.totals['AnalyzerError']);
-  activeInfoTypes.forEach((type) => appendCount(counter.totals['$type']));
+  activeInfoTypes.forEach((t) => appendCount(counter.totals[t]));
   appendCount(counter.totalLinesOfCode);
 
   appendPercent(count, total) {
     if (count == null) count = 0;
     var value = (count * 100 / total).toStringAsFixed(2);
     table.addEntry(value);
   }
 
   var totalLOC = counter.totalLinesOfCode;
   table.addEntry('%');
   appendPercent(counter.totals['AnalyzerError'], totalLOC);
-  activeInfoTypes
-      .forEach((type) => appendPercent(counter.totals['$type'], totalLOC));
+  activeInfoTypes.forEach((t) => appendPercent(counter.totals[t], totalLOC));
   appendCount(100);
 
   return table.toString();
 }
 
 /// Helper class to combine all the information in table form.
 class _Table {
   int _totalColumns = 0;
   int get totalColumns => _totalColumns;
 
@@ skipping 134 matching lines @@
 
   visitMessage(MessageSummary message) {
     var kind = message.kind;
     errorCount.putIfAbsent(currentPackage, () => <String, int>{});
     errorCount[currentPackage].putIfAbsent(kind, () => 0);
     errorCount[currentPackage][kind]++;
     totals.putIfAbsent(kind, () => 0);
     totals[kind]++;
   }
 }