expose strong checker API, for use by analyzer_cli

expose strong checker API, for use by analyzer_cli
most of the changes here are around making options sane(r), which fixes #204

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/0ff64c1c9805e8fe6406e2acb05e34891d2f9f83

[Jennifer Messerly, 2015-06-10 22:21:31]

Patchset #2 (id:20001) has been deleted

[Jennifer Messerly, 2015-06-10 22:21:38]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2015-06-10 22:34:16]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2015-06-10 22:34:18]

This is the dev_compiler side of changes (by far the bulk).
Will link analyzer_cli changes shortly, but wanted to get this out.

The basic usage is really simple, though ... create a StrongChecker, then call
computeErrors, passing it a Source.

https://codereview.chromium.org/1174643003/diff/40001/lib/src/options.dart
File lib/src/options.dart (right):

https://codereview.chromium.org/1174643003/diff/40001/lib/src/options.dart#ne...
lib/src/options.dart:76: final StrongModeOptions strongOptions;
decided to go composition over inheritance. Seemed to work out. Less duplication
in the initialization, still immutable.

https://codereview.chromium.org/1174643003/diff/40001/lib/src/testing.dart
File lib/src/testing.dart (right):

https://codereview.chromium.org/1174643003/diff/40001/lib/src/testing.dart#ne...
lib/src/testing.dart:50: void testChecker(Map<String, String> testFiles, {String
sdkDir,
big refactor here to switch it to test StrongChecker, so we get coverage. It
understands analysis errors now instead of our Message objects. Makes it a
partial fix for issue #6.

https://codereview.chromium.org/1174643003/diff/40001/lib/src/testing.dart#ne...
lib/src/testing.dart:193: '$levelName: ${span.message(expected.typeName, color:
colorOf(levelName))}';
oops, forgot dart_style can't handle this. will fix

https://codereview.chromium.org/1174643003/diff/40001/lib/src/testing.dart#ne...
lib/src/testing.dart:208: return '$levelName: ${span.message(actual.message,
color: colorOf(levelName))}';
this too

https://codereview.chromium.org/1174643003/diff/40001/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1174643003/diff/40001/lib/src/utils.dart#newc...
lib/src/utils.dart:23: NodeLocator,
will revert this.

https://codereview.chromium.org/1174643003/diff/40001/test/report_test.dart
File test/report_test.dart (left):

https://codereview.chromium.org/1174643003/diff/40001/test/report_test.dart#o...
test/report_test.dart:34: testChecker(files,
this wasn't really using testChecker for anything ... when reporter was set, it
bypassed all of the error validation. It was just used for creating the Compiler
instance, so inlined that here.

[Jennifer Messerly, 2015-06-10 22:43:18]

https://github.com/dart-lang/analyzer_cli/commit/d6b65c4aaf84fbb78159f6ec6490...
shows the analyzer_cli side. Perhaps worth making a pull request for that, not
sure. I'd feel better adding a test over there.

Oh, we also need: to publish DDC to Pub, and figure out how to pull
it+transitive deps into SDK repo.

[Jennifer Messerly, 2015-06-10 22:44:00]

On 2015/06/10 22:43:18, John Messerly wrote:
>
https://github.com/dart-lang/analyzer_cli/commit/d6b65c4aaf84fbb78159f6ec6490...
> shows the analyzer_cli side. Perhaps worth making a pull request for that, not
> sure. I'd feel better adding a test over there.
> 
> Oh, we also need: to publish DDC to Pub, and figure out how to pull
> it+transitive deps into SDK repo.

oops, meant to link branch https://github.com/dart-lang/analyzer_cli/tree/ddc

[vsm, 2015-06-10 23:31:17]

lgtm!

https://codereview.chromium.org/1174643003/diff/60001/lib/strong_mode.dart
File lib/strong_mode.dart (right):

https://codereview.chromium.org/1174643003/diff/60001/lib/strong_mode.dart#ne...
lib/strong_mode.dart:92: /// Whether to infer return types and field types from
overriden members.
overriden -> overridden

[Jennifer Messerly, 2015-06-11 14:46:48]

https://codereview.chromium.org/1174643003/diff/60001/lib/strong_mode.dart
File lib/strong_mode.dart (right):

https://codereview.chromium.org/1174643003/diff/60001/lib/strong_mode.dart#ne...
lib/strong_mode.dart:92: /// Whether to infer return types and field types from
overriden members.
On 2015/06/10 23:31:17, vsm wrote:
> overriden -> overridden

Good catch. Done. Also fixed this typo in a few more places in DDC :-)

fwiw, it also appears in `_overridenTypes` in analyzer's resolver.dart file
(TypeOverrideManager_TypeOverrideScope)

And in SDK documentation for convert/utf.dart, wow.

[Jennifer Messerly, 2015-06-11 14:47:17]

Committed patchset #3 (id:80001) manually as
0ff64c1c9805e8fe6406e2acb05e34891d2f9f83 (presubmit successful).

[Jennifer Messerly, 2015-06-11 14:55:30]

fyi, landed this so I can build on the internals of it (e.g. to fix DDC to use
AnalysisErrors internally https://github.com/dart-lang/dev_compiler/issues/6)

Paul & Phil, very happy to hear your feedback on the StrongChecker/Options APIs
... they are all subject to change until the analyzer_cli changes look good to
you guys too :). I'm not quite ready to officially send out the analyzer_cli
side though... need to add tests, and start chasing down DEPS dependency issues.