Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1174633002: [Android] Use large_output for calls to "ps" and "dumpsys batterystats". (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, telemetry-reviews_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Use large_output for calls to "ps" and "dumpsys batterystats". BUG= Committed: https://crrev.com/6419e5402e8d17795ead100074ce18f7ed09f4d2 Cr-Commit-Position: refs/heads/master@{#333584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M build/android/pylib/device/battery_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbudorick
This should eliminate this: WARNING:root:2015-06-09 03:16:00,692:exit status of shell command 'cat /data/local/tmp/temp_file-1433844960-475363' missing. ERROR:root:2015-06-09 03:16:00,692:No ...
5 years, 6 months ago (2015-06-09 17:56:32 UTC) #2
rnephew (Reviews Here)
Not that it matters but, LGTM.
5 years, 6 months ago (2015-06-09 19:11:21 UTC) #3
jbudorick
On 2015/06/09 at 19:11:21, rnephew wrote: > Not that it matters but, LGTM. Soon. (Also, ...
5 years, 6 months ago (2015-06-09 19:11:57 UTC) #4
sullivan
lgtm
5 years, 6 months ago (2015-06-09 20:27:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174633002/1
5 years, 6 months ago (2015-06-09 20:43:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 22:00:59 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 22:01:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6419e5402e8d17795ead100074ce18f7ed09f4d2
Cr-Commit-Position: refs/heads/master@{#333584}

Powered by Google App Engine
This is Rietveld 408576698