Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1174623002: Add boxShadow to BoxDecoration#toString (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sky/sdk/lib/framework/rendering/box.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-09 17:39:46 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as f333edfa85bbeea207f4821dbc9edd7204652de0 (presubmit successful).
5 years, 6 months ago (2015-06-09 17:39:56 UTC) #2
Hixie
LGTM, but for bonus points you could have it print out: boxShadow #1: ... boxShadow ...
5 years, 6 months ago (2015-06-09 17:56:06 UTC) #3
Hixie
5 years, 6 months ago (2015-06-09 17:56:14 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698