Issue 1174603002: Revert of Optimize trivial regexp disjunctions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1174603002: Revert of Optimize trivial regexp disjunctions (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org

Modified:
5 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Optimize trivial regexp disjunctions (patchset #10 id:180001 of https://codereview.chromium.org/1176453002/) Reason for revert: ASAN failure Original issue's description: > Optimize trivial regexp disjunctions > > R=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/5f1f7c15b3207f6c51d187692690aeb09d3e36b5 > Cr-Commit-Position: refs/heads/master@{#28871} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Committed: https://crrev.com/b75bf6cd7e63900c7fb6b12851d5dcfe78e1c864 Cr-Commit-Position: refs/heads/master@{#28878}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -259 lines)			Patch
M	src/ast.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/jsregexp.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jsregexp.cc	View	1 chunk	+0 lines, -181 lines	0 comments	Download
M	src/list.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/list-inl.h	View	2 chunks	+4 lines, -31 lines	0 comments	Download
M	src/vector.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	test/mjsunit/regress/regress-chromium-482998.js	View	1 chunk	+0 lines, -22 lines	0 comments	Download

Total messages: 4 (0 generated)

Erik Corry Chromium.org

Created Revert of Optimize trivial regexp disjunctions

5 years, 6 months ago (2015-06-09 17:14:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174603002/1

5 years, 6 months ago (2015-06-09 17:14:56 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-09 17:16:07 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b75bf6cd7e63900c7fb6b12851d5dcfe78e1c864
Cr-Commit-Position: refs/heads/master@{#28878}