Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 11746019: Introduce callback interface for running Javascript asynchronously in the renderer. (Closed)

Created:
7 years, 11 months ago by Avi (use Gerrit)
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Introduce callback interface for running Javascript asynchronously in the renderer. BUG=168169 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175051

Patch Set 1 #

Patch Set 2 : includes #

Patch Set 3 : more includes #

Total comments: 2

Patch Set 4 : .insert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -23 lines) Patch
M content/browser/renderer_host/render_view_host_impl.h View 5 chunks +16 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 chunks +31 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/render_view_host.h View 5 chunks +28 lines, -8 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
John for review, Darin FYI.
7 years, 11 months ago (2013-01-03 18:33:01 UTC) #1
jam
https://codereview.chromium.org/11746019/diff/8002/content/public/browser/render_view_host.h File content/public/browser/render_view_host.h (right): https://codereview.chromium.org/11746019/diff/8002/content/public/browser/render_view_host.h#newcode184 content/public/browser/render_view_host.h:184: virtual int ExecuteJavascriptInWebFrameNotifyResult( what's the plan for removing this? ...
7 years, 11 months ago (2013-01-03 20:53:02 UTC) #2
Avi (use Gerrit)
I have in my local repo a CL ready to go moving the Apple Event ...
7 years, 11 months ago (2013-01-03 21:01:53 UTC) #3
jam
lgtm
7 years, 11 months ago (2013-01-03 22:07:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11746019/10001
7 years, 11 months ago (2013-01-03 22:25:00 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-03 23:42:14 UTC) #6
Message was sent while issue was closed.
Change committed as 175051

Powered by Google App Engine
This is Rietveld 408576698