[webui] whittle down a few more uses of old-style templateData

[webui] whittle down a few more uses of old-style templateData

BUG=122753
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175261

[Dan Beam, 2013-01-03 04:55:23]

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/cert...
File chrome/browser/resources/certificate_viewer.js (left):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/cert...
chrome/browser/resources/certificate_viewer.js:15:
i18nTemplate.process(document, templateData);
did it matter than the process happen before other stuff here?

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/flag...
File chrome/browser/resources/flags.css (right):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags.css:33: background-repeat: no-repeat;
what's the point of this change?

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/flag...
File chrome/browser/resources/flags_warning.html (left):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags_warning.html:30: <script
src="chrome://flags/flags.js"></script>
why don't you need this any more?

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/poli...
File chrome/browser/resources/policy.html (right):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/poli...
chrome/browser/resources/policy.html:156: <script
src="chrome://resources/js/i18n_template2.js"></script>
nit: can you put inside the body?

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/poli...
File chrome/browser/resources/policy.js (left):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/poli...
chrome/browser/resources/policy.js:251: i18nTemplate.process(document,
templateData);
why was this here?

https://codereview.chromium.org/11746012/diff/1/chrome/browser/ui/webui/about...
File chrome/browser/ui/webui/about_ui.cc (right):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/ui/webui/about...
chrome/browser/ui/webui/about_ui.cc:944: jstemplate_builder::UseVersion2
version2;
what else in this file makes you used a scoped UseVersion2 thinger?

[Evan Stade, 2013-01-03 05:31:23]

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/cert...
File chrome/browser/resources/certificate_viewer.js (left):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/cert...
chrome/browser/resources/certificate_viewer.js:15:
i18nTemplate.process(document, templateData);
On 2013/01/03 04:55:23, Dan Beam wrote:
> did it matter than the process happen before other stuff here?

don't think so, the page still seems to work.

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/flag...
File chrome/browser/resources/flags.css (right):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags.css:33: background-repeat: no-repeat;
On 2013/01/03 04:55:23, Dan Beam wrote:
> what's the point of this change?

no point any more, removed.

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/flag...
File chrome/browser/resources/flags_warning.html (left):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags_warning.html:30: <script
src="chrome://flags/flags.js"></script>
On 2013/01/03 04:55:23, Dan Beam wrote:
> why don't you need this any more?

it was never needed

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/poli...
File chrome/browser/resources/policy.html (right):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/poli...
chrome/browser/resources/policy.html:156: <script
src="chrome://resources/js/i18n_template2.js"></script>
On 2013/01/03 04:55:23, Dan Beam wrote:
> nit: can you put inside the body?

Done.

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/poli...
File chrome/browser/resources/policy.js (left):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/resources/poli...
chrome/browser/resources/policy.js:251: i18nTemplate.process(document,
templateData);
On 2013/01/03 04:55:23, Dan Beam wrote:
> why was this here?

i believe it was here because i18n_process was at the beginning of the html file
(it has to come at the end)

https://codereview.chromium.org/11746012/diff/1/chrome/browser/ui/webui/about...
File chrome/browser/ui/webui/about_ui.cc (right):

https://codereview.chromium.org/11746012/diff/1/chrome/browser/ui/webui/about...
chrome/browser/ui/webui/about_ui.cc:944: jstemplate_builder::UseVersion2
version2;
On 2013/01/03 04:55:23, Dan Beam wrote:
> what else in this file makes you used a scoped UseVersion2 thinger?

nothing, that's why it's local here

[Dan Beam, 2013-01-03 21:24:21]

lgtm

[commit-bot: I haz the power, 2013-01-04 01:35:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/11746012/3005

[commit-bot: I haz the power, 2013-01-04 01:35:18]

Presubmit check for 11746012-3005 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org or dbeam@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in chrome/browser/resources/about_memory.js:
  line 6: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  if (document.getElementById('helpTooltip'))
      ^^^^^^^^^^^^^^^^^^^^^^^
  line 62: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  var el = document.getElementById('helpTooltip');
           ^^^^^^^^^^^^^^^^^^^^^^^
  line 78: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  var output = document.getElementById('t');
               ^^^^^^^^^^^^^^^^^^^^^^^
  line 45: E0001: Extra space before ")"
  if (event.pageX - width - 50 + document.body.scrollLeft >= 0 ) {
                                                              ^
  line 75: E0001: Extra space after "function"
document.addEventListener('DOMContentLoaded', function () {
                                                      ^

Presubmit checks took 2.1s to calculate.