Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 11746010: Cleanup history favicon code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_service.cc ('k') | chrome/browser/history/history.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/android/android_provider_backend_unittest.cc
diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc
index fe034ebf5984da253de572fadfd524e25de82752..e3831008933f5f19439e08c62afee4645d3a5bd9 100644
--- a/chrome/browser/history/android/android_provider_backend_unittest.cc
+++ b/chrome/browser/history/android/android_provider_backend_unittest.cc
@@ -255,15 +255,7 @@ TEST_F(AndroidProviderBackendTest, UpdateTables) {
std::vector<history::FaviconBitmapData> favicon_bitmap_data;
favicon_bitmap_data.push_back(bitmap_data_element);
- FaviconSizes favicon_sizes;
- favicon_sizes.push_back(gfx::Size());
- IconURLSizesMap icon_url_sizes;
- icon_url_sizes[GURL()] = favicon_sizes;
-
- history_backend->SetFavicons(url2,
- FAVICON,
- favicon_bitmap_data,
- icon_url_sizes);
+ history_backend->SetFavicons(url2, FAVICON, favicon_bitmap_data);
history_backend->Closing();
}
@@ -413,15 +405,7 @@ TEST_F(AndroidProviderBackendTest, QueryHistoryAndBookmarks) {
std::vector<history::FaviconBitmapData> favicon_bitmap_data;
favicon_bitmap_data.push_back(bitmap_data_element);
- FaviconSizes favicon_sizes;
- favicon_sizes.push_back(gfx::Size());
- IconURLSizesMap icon_url_sizes;
- icon_url_sizes[GURL()] = favicon_sizes;
-
- history_backend->SetFavicons(url2,
- FAVICON,
- favicon_bitmap_data,
- icon_url_sizes);
+ history_backend->SetFavicons(url2, FAVICON, favicon_bitmap_data);
history_backend->Closing();
}
@@ -1835,15 +1819,7 @@ TEST_F(AndroidProviderBackendTest, QueryWithoutThumbnailDB) {
std::vector<history::FaviconBitmapData> favicon_bitmap_data;
favicon_bitmap_data.push_back(bitmap_data_element);
- FaviconSizes favicon_sizes;
- favicon_sizes.push_back(gfx::Size());
- IconURLSizesMap icon_url_sizes;
- icon_url_sizes[GURL()] = favicon_sizes;
-
- history_backend->SetFavicons(url2,
- FAVICON,
- favicon_bitmap_data,
- icon_url_sizes);
+ history_backend->SetFavicons(url2, FAVICON, favicon_bitmap_data);
history_backend->Closing();
}
« no previous file with comments | « chrome/browser/favicon/favicon_service.cc ('k') | chrome/browser/history/history.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698