Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: src/frames.cc

Issue 1174593003: [frames] No GC is allowed while using the unhandlified TranslatedState. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 644a0b3ec7391a6d5e7658b98e8bbec885eb1c8f..0b6942183990f92aa3676732b73ee09f2f0389cd 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -886,6 +886,7 @@ void OptimizedFrame::Summarize(List<FrameSummary>* frames) {
// We create the summary in reverse order because the frames
// in the deoptimization translation are ordered bottom-to-top.
+ DisallowHeapAllocation no_gc;
TranslatedState state(this);
bool is_constructor = IsConstructor();
for (TranslatedFrame const& frame : state) {
@@ -987,6 +988,7 @@ void OptimizedFrame::GetFunctions(List<JSFunction*>* functions) {
return JavaScriptFrame::GetFunctions(functions);
}
+ DisallowHeapAllocation no_gc;
TranslatedState state(this);
for (TranslatedFrame const& frame : state) {
if (frame.kind() == TranslatedFrame::kFunction) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698