Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1174593003: [frames] No GC is allowed while using the unhandlified TranslatedState. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[frames] No GC is allowed while using the unhandlified TranslatedState. R=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/472b147708ba585f07c0020434302d96867cbb61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/frames.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-10 05:06:49 UTC) #1
Benedikt Meurer
Hey Jaro, The change we talked about yesterday. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-10 05:07:30 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-10 05:10:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174593003/1
5 years, 6 months ago (2015-06-10 05:10:58 UTC) #5
Benedikt Meurer
5 years, 6 months ago (2015-06-10 05:16:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
472b147708ba585f07c0020434302d96867cbb61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698