Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Unified Diff: pkg/analyzer/test/src/task/dart_test.dart

Issue 1174563003: Fix the test to remove extra hint. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Respect AnalysisOptions.hint == false. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/dart_test.dart
diff --git a/pkg/analyzer/test/src/task/dart_test.dart b/pkg/analyzer/test/src/task/dart_test.dart
index cfbfc2e06cd2308d37125ff33969a5cedc7348e0..08cf3615889afd4dd2ad95fbddaadb05e408ed08 100644
--- a/pkg/analyzer/test/src/task/dart_test.dart
+++ b/pkg/analyzer/test/src/task/dart_test.dart
@@ -8,7 +8,8 @@ import 'package:analyzer/src/context/cache.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/constant.dart';
import 'package:analyzer/src/generated/element.dart';
-import 'package:analyzer/src/generated/engine.dart' show CacheState;
+import 'package:analyzer/src/generated/engine.dart'
+ show AnalysisOptionsImpl, CacheState;
import 'package:analyzer/src/generated/error.dart';
import 'package:analyzer/src/generated/resolver.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -1898,6 +1899,21 @@ main() {
errorListener.assertErrorsWithCodes(<ErrorCode>[HintCode.DEAD_CODE]);
}
+ test_perform_disabled() {
+ context.analysisOptions =
+ new AnalysisOptionsImpl.from(context.analysisOptions)..hint = false;
+ Source source = newSource('/test.dart', '''
+int main() {
+}
+''');
+ LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
+ _computeResult(target, HINTS);
+ expect(task, new isInstanceOf<GenerateHintsTask>());
+ // validate
+ _fillErrorListener(HINTS);
+ errorListener.assertNoErrors();
+ }
+
test_perform_imports_duplicateImport() {
newSource('/a.dart', r'''
library lib_a;
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698