ppapi: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

ppapi: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/.

BUG=465354
TBR=sievers@chromium.org

Committed: https://crrev.com/23490d44633f4eaeb76e03384e08e9fd3ef2909a
Cr-Commit-Position: refs/heads/master@{#334148}

[Sami, 2015-06-09 18:21:40]

skyostil@chromium.org changed reviewers:
+ bbudge@chromium.org

[bbudge, 2015-06-10 20:57:47]

Overall it looks good. There are now some obsolete method names in the Pepper
code that it would be nice to fix. I think it should be straightforward
renaming.

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/message_handler.cc
File ppapi/proxy/message_handler.cc (right):

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/message_handler...
ppapi/proxy/message_handler.cc:116:
message_loop_->message_loop_proxy()->PostTask(
Looks like this was missed.

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppapi_proxy_test.h
File ppapi/proxy/ppapi_proxy_test.h (right):

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppapi_proxy_tes...
ppapi/proxy/ppapi_proxy_test.h:28: class SingleThreadTaskRunner;
Alphabetical ordering

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppb_message_loo...
File ppapi/proxy/ppb_message_loop_proxy.cc (right):

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppb_message_loo...
ppapi/proxy/ppb_message_loop_proxy.cc:194: base::SingleThreadTaskRunner*
MessageLoopResource::GetMessageLoopProxy() {
Name 'GetMessageLoopProxy' is now misleading.

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppb_message_loo...
File ppapi/proxy/ppb_message_loop_proxy.h (right):

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppb_message_loo...
ppapi/proxy/ppb_message_loop_proxy.h:47: const
scoped_refptr<base::SingleThreadTaskRunner>& message_loop_proxy() {
Method name 'message_loop_proxy' is now misleading.

[Sami, 2015-06-11 18:03:46]

Thanks for the review. I've now done the renames you pointed out and nothing
seemed to break. PTAL.

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/message_handler.cc
File ppapi/proxy/message_handler.cc (right):

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/message_handler...
ppapi/proxy/message_handler.cc:116:
message_loop_->message_loop_proxy()->PostTask(
On 2015/06/10 20:57:46, bbudge wrote:
> Looks like this was missed.

message_loop_ is a MessageLoopResource, not a base::MessageLoop, so I wasn't
sure if I should be reworking it or not. I was under the impression that PPAPI
defines some interfaces that are called from the runtime, so I was careful about
not changing too many things. Do you think this function should be renamed too?

Edit: scratch that, I've now renamed it too.

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppapi_proxy_test.h
File ppapi/proxy/ppapi_proxy_test.h (right):

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppapi_proxy_tes...
ppapi/proxy/ppapi_proxy_test.h:28: class SingleThreadTaskRunner;
On 2015/06/10 20:57:46, bbudge wrote:
> Alphabetical ordering

Thanks, fixed.

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppb_message_loo...
File ppapi/proxy/ppb_message_loop_proxy.cc (right):

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppb_message_loo...
ppapi/proxy/ppb_message_loop_proxy.cc:194: base::SingleThreadTaskRunner*
MessageLoopResource::GetMessageLoopProxy() {
On 2015/06/10 20:57:46, bbudge wrote:
> Name 'GetMessageLoopProxy' is now misleading.

Done.

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppb_message_loo...
File ppapi/proxy/ppb_message_loop_proxy.h (right):

https://codereview.chromium.org/1174543002/diff/1/ppapi/proxy/ppb_message_loo...
ppapi/proxy/ppb_message_loop_proxy.h:47: const
scoped_refptr<base::SingleThreadTaskRunner>& message_loop_proxy() {
On 2015/06/10 20:57:46, bbudge wrote:
> Method name 'message_loop_proxy' is now misleading.

Agreed, let me try renaming it and seeing what breaks :)

[bbudge, 2015-06-12 01:03:17]

Thanks for doing that. I assume the test failures are because your patch to the
tests is needed to create a message loop.

LGTM

[Sami, 2015-06-12 11:11:26]

On 2015/06/12 01:03:17, bbudge wrote:
> Thanks for doing that. I assume the test failures are because your patch to
the
> tests is needed to create a message loop.

That's right -- turns out there was already a message loop on the failing test
but it was created in the wrong order w.r.t PPapiGlobals.

I'll TBR that test tweak to sievers@.

[Sami, 2015-06-12 11:11:39]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2015-06-12 11:11:39]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/1174543002/#ps40001
(title: "Fix V8VarConverterTest.")

[commit-bot: I haz the power, 2015-06-12 11:12:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174543002/40001

[commit-bot: I haz the power, 2015-06-12 12:54:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-12 12:55:47]

Patchset 3 (id:??) landed as
https://crrev.com/23490d44633f4eaeb76e03384e08e9fd3ef2909a
Cr-Commit-Position: refs/heads/master@{#334148}