Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1174533002: [DevTools] Add DevToolsSanityTest.TestSettings. (Closed)

Created:
5 years, 6 months ago by dgozman
Modified:
5 years, 6 months ago
Reviewers:
sergeyv, pfeldman
CC:
chromium-reviews, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@1157633007
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add DevToolsSanityTest.TestSettings. BUG=none Committed: https://crrev.com/0fced85f4828a4c63b34ceab26a587669f2dd801 Cr-Commit-Position: refs/heads/master@{#333735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years, 6 months ago (2015-06-09 12:22:15 UTC) #2
pfeldman
lgtm
5 years, 6 months ago (2015-06-09 12:27:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174533002/1
5 years, 6 months ago (2015-06-10 14:26:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 15:06:11 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 15:06:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fced85f4828a4c63b34ceab26a587669f2dd801
Cr-Commit-Position: refs/heads/master@{#333735}

Powered by Google App Engine
This is Rietveld 408576698