Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: gm/rebaseline_server/static/loader.js

Issue 117453002: rebaseline_server: return rebaseline results faster, and reload UI page automatically after (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/server.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/static/loader.js
diff --git a/gm/rebaseline_server/static/loader.js b/gm/rebaseline_server/static/loader.js
index fa74ed8eff04583e743fc47ba401e8e80b7f6509..3339cad4a9e1844b2c73a4944e377ff8c14646df 100644
--- a/gm/rebaseline_server/static/loader.js
+++ b/gm/rebaseline_server/static/loader.js
@@ -55,7 +55,7 @@ Loader.controller(
function(data, status, header, config) {
if (data.header.resultsStillLoading) {
$scope.loadingMessage =
- "Server is still loading initial results; will retry at " +
+ "Server is still loading results; will retry at " +
$scope.localTimeString(data.header.timeNextUpdateAvailable);
$timeout(
function(){location.reload();},
@@ -508,9 +508,13 @@ Loader.controller(
alert("New baselines submitted successfully!\n\n" +
"You still need to commit the updated expectations files on " +
"the server side to the Skia repo.\n\n" +
- "Also: in order to see the complete updated data, or to submit " +
- "more baselines, you will need to reload your client.");
- $scope.submitPending = false;
+ "When you click OK, your web UI will reload; after that " +
+ "completes, you will see the updated data (once the server has " +
+ "finished loading the update results into memory!) and you can " +
+ "submit more baselines if you want.");
+ // I don't know why, but if I just call reload() here it doesn't work.
+ // Making a timer call it fixes the problem.
+ $timeout(function(){location.reload();}, 1);
}).error(function(data, status, headers, config) {
alert("There was an error submitting your baselines.\n\n" +
"Please see server-side log for details.");
« no previous file with comments | « gm/rebaseline_server/server.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698