Issue 117453002: rebaseline_server: return rebaseline results faster, and reload UI page automatically after

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 117453002: rebaseline_server: return rebaseline results faster, and reload UI page automatically after (Closed)

Created:
7 years ago by epoger

Modified:
7 years ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

rebaseline_server: return rebaseline results faster, and reload UI page automatically after Old way: Wait until server has loaded the updated results before telling the user the rebaseline was successful, and trust the user to reload the page before submitting more baselines. New way: Make server load the updated results in a separate thread, and automatically reload the page so that the user can submit more baselines if she wants to. (SkipBuildbotRuns) NOTRY=True NOTREECHECKS=True Committed: http://code.google.com/p/skia/source/detail?r=12717

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -9 lines)			Patch
	M	gm/rebaseline_server/server.py	View		3 chunks	+15 lines, -5 lines	0 comments	Download
	M	gm/rebaseline_server/static/loader.js	View		2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

epoger

Ready for review at patchset 1. You can try it out at http://172.24.179.183:9133/ if you ...

7 years ago (2013-12-17 17:49:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/117453002/1

7 years ago (2013-12-17 18:06:08 UTC) #3

Message was sent while issue was closed.

Change committed as 12717

Expand Messages | Collapse Messages