Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1174503002: add missing zlib dep after CL 1148633007 (Closed)

Created:
5 years, 6 months ago by Mostyn Bramley-Moore
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add missing zlib dep after CL 1148633007 This previous CL included our patched version of zlib.h, but forgot to add the dependency in gyp/gn, making it possible to compile with the locally patched version and link with a system version (which will fail due to unresolved MOZ_Z_* symbols): https://codereview.chromium.org/1148633007 BUG=466769 Committed: https://crrev.com/936c5dd07832efe4b2ef9753a9d7e99a4350d4ff Cr-Commit-Position: refs/heads/master@{#333510}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@David, Øystein: please take a look at this zlib dependency fixup...
5 years, 6 months ago (2015-06-09 10:56:25 UTC) #2
davidben
lgtm
5 years, 6 months ago (2015-06-09 15:11:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174503002/20001
5 years, 6 months ago (2015-06-09 15:17:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 16:55:36 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 16:56:32 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/936c5dd07832efe4b2ef9753a9d7e99a4350d4ff
Cr-Commit-Position: refs/heads/master@{#333510}

Powered by Google App Engine
This is Rietveld 408576698