Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 11745027: Replaced a bailout ID assertion with quadratic time complexity by a linear one. (Closed)

Created:
7 years, 11 months ago by Sven Panne
Modified:
7 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Replaced a bailout ID assertion with quadratic time complexity by a linear one. This reduces the time to run our test suite in debug mode considerably (from 8:43 to 4:05 on my local workstation using 32 threads). Note that the assertion is so fast now that it doesn't need to be hidden behind --enable-slow-asserts. Furthermore, the bookkeeping of the set is not measurable in all our benchmarks, so I intentionally avoided any #ifdef chaos to keep things simple. Committed: http://code.google.com/p/v8/source/detail?r=13312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -46 lines) Patch
M src/data-flow.h View 1 chunk +34 lines, -0 lines 0 comments Download
M src/full-codegen.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M src/lithium-allocator.h View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
7 years, 11 months ago (2013-01-04 12:23:31 UTC) #1
Toon Verwaest
7 years, 11 months ago (2013-01-04 12:47:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698