Synced Notification Sync Change Processor

sync/protocol/server_data.proto

Index: sync/protocol/server_data.proto
diff --git a/sync/protocol/server_data.proto b/sync/protocol/server_data.proto
new file mode 100644
index 0000000000000000000000000000000000000000..44294a2a769c4ffd1cfb37071626f2605c3f5aad
--- /dev/null
+++ b/sync/protocol/server_data.proto
@@ -0,0 +1,82 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Sync protocol datatype extension for push notifications..
+
+// Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
+// any fields in this file.
+
+syntax = "proto2";
+
+option optimize_for = LITE_RUNTIME;
+option retain_unknown_fields = true;
+
+package sync_pb;
+
+import "server_render.proto";
+

[Nicolas Zea, 2013/01/05 01:18:48]

remove extra newline

[Pete Williamson, 2013/01/18 18:58:39]

Done.

+
+// This message allows clients to identify a notification they have created.
+// IMPORTANT: Everything in this message may be sent to the client in clear text
+// - do not expose any user ids, internal product names, credit card numbers,
+// etc... anywhere in the message.
+message Identifier {

[Nicolas Zea, 2013/01/05 01:18:48]

Given that these are all going to be part of the same namespace, and their
similarity to existing sync message, I'd prefer more specific names. For
example: SyncedNotificationIdentifier, SyncedNotificationData, and
SyncedNotificationCoalescedData.

Same in server_render.proto

[Pete Williamson, 2013/01/18 18:58:39]

Done.

+  // The application that the notification is a part of.
+  //
+  // IMPORTANT: This string may be sent to the client in clear text - do not
+  // expose any user ids, internal product names, credit card numbers, etc...
+  optional string app_id = 1;
+
+  // Notifications with the same coalescing key (isolated to the same app_id)
+  // will be grouped together when fetched.
+  //
+  // IMPORTANT: This string may be sent to the client in clear text - do not
+  // expose any user ids, internal product names, credit card numbers, etc...
+  optional string coalescing_key = 2;
+}
+
+message Notification {
+  // The unique identifier to identify the notification.
+  optional Identifier id = 1;
+
+  // A secondary type that is isolated within the same app_id.
+  //
+  // NOTE: For ASBE support purposes this must be in the format [A-Za-z_]+.
+  //
+  // IMPORTANT: This string may be sent to the client in clear text - do not
+  // expose any user ids, internal product names, credit card numbers, etc...
+  optional string type = 2;
+
+  // Whatever string the client entered during creation.  If no external_id is
+  // specified, the notification can no longer be identified individually for
+  // fetching/deleting, etc...
+  //
+  // IMPORTANT: This string may be sent to the client in clear text - do not
+  // expose any user ids, internal product names, credit card numbers, etc...
+  optional string external_id = 3;
+}
+
+message CoalescedNotification {
+  // The identifier used to identify individual coalesced notifications.
+  optional Identifier id = 1;
+
+  // All the notifications that are grouped together.
+  repeated Notification notification = 2;
+
+  // Data that is used directly by endpoints to render notifications in the case
+  // where no "native" app can handle the notification.
+  optional RenderInfo render_info = 3;
+
+  // Read state will be per coalesced notification.
+  enum ReadState {
+    UNREAD = 1;
+    READ = 2;
+    DISMISSED = 3;
+  }
+  optional ReadState read_state = 4;
+
+  // The time when the LATEST notification of the coalesced notification is
+  // created (in Java time milliseconds).
+  optional uint64 creation_time_msec = 5;
+}