chrome/browser/notifier/chrome_notifier_delegate.cc - Issue 11745024: Synced Notification Sync Change Processor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/notifier/chrome_notifier_delegate.cc

Issue 11745024: Synced Notification Sync Change Processor (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: SyncedNotifications - first round of CR comment fixes. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/notifier/chrome_notifier_delegate.h ('K') | « chrome/browser/notifier/chrome_notifier_delegate.h ('k') | chrome/browser/notifier/chrome_notifier_service.h » ('j') | chrome/browser/notifier/chrome_notifier_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // ChromeNotifierDelegate is a NotificationDelegate which catches

	6 // responses from the NotificationUIManager when a notification

	7 // has been closed.
	dcheng 2013/01/18 21:56:13 Duplicate comment? This would be a good place to t Duplicate comment? This would be a good place to talk about tricky implementation details if needed. Pete Williamson 2013/01/23 01:45:55 Yep, this is a dup, removed. (my theory is that cl Show quoted text On 2013/01/18 21:56:13, dcheng wrote: > Duplicate comment? This would be a good place to talk about tricky > implementation details if needed. Yep, this is a dup, removed. (my theory is that class comment duplication is good, I've removed it since you seem to disagree.)
	8

	9 #include "chrome/browser/notifier/chrome_notifier_delegate.h"

	10

	11 #include <string>
	dcheng 2013/01/18 21:56:13 You shouldn't need this #include here or the .h. I You shouldn't need this #include here or the .h. If you do, that's a sign that a header file elsewhere isn't including it when it should be. Pete Williamson 2013/01/23 01:45:55 Done. Show quoted text On 2013/01/18 21:56:13, dcheng wrote: > You shouldn't need this #include here or the .h. If you do, that's a sign that a > header file elsewhere isn't including it when it should be. Done.
	12

	13 void ChromeNotifierDelegate::Close(bool by_user) {

	14 // TODO(petewil): implement

	15 }

OLD	NEW