Synced Notification Sync Change Processor

sync/protocol/synced_notification_specifics.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Sync protocol datatype extension for synced notifications.
 
 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
 // any fields in this file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 option retain_unknown_fields = true;
 
 package sync_pb;
 
+import "server_render.proto";

[Nicolas Zea, 2013/01/05 01:18:48]

Are you planning to reuse these protos anywhere? If not, I think I'd prefer
having them inlined.

Otherwise, the files should be renamed to make it clearer that they're specifics
to the SyncedNotification datatype. "Server Data" in particular  sounds like it
related to the sync engine.

[Pete Williamson, 2013/01/18 18:58:39]

Yes, these are being matched by a similar set of protos on the server side.

+import "server_data.proto";
+
 // Properties of SyncedNotificationSpecifics objects.
 message SyncedNotificationSpecifics {
-  // TODO(petewil): this is placeholder data, make a real one
+  // The notification from the server
+  // TODO(petewil): is this always coalesced, or sometimes a plain notification?
+  optional CoalescedNotification coalesced_notification = 1;
 }