- Make Boolean 'true' and 'false' singleton VM isolate objects.

vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 4969 matching lines @@
   } else if ((CurrentToken() == Token::kDOUBLE) &&
       (no_check || type.IsDoubleType() || type.IsNumberType())) {
     *value = CurrentDoubleLiteral();
     return true;
   } else if ((CurrentToken() == Token::kSTRING) &&
       (no_check || type.IsStringType())) {
     *value = CurrentLiteral()->raw();
     return true;
   } else if ((CurrentToken() == Token::kTRUE) &&
       (no_check || type.IsBoolType())) {
-    *value = Bool::True();
+    *value = Bool::True().raw();
     return true;
   } else if ((CurrentToken() == Token::kFALSE) &&
       (no_check || type.IsBoolType())) {
-    *value = Bool::False();
+    *value = Bool::False().raw();
     return true;
   } else if (CurrentToken() == Token::kNULL) {
     *value = Instance::null();
     return true;
   }
   return false;
 }
 
 
 // Returns true if the current token is kIDENT or a pseudo-keyword.
@@ skipping 4212 matching lines @@
   String* ident = ExpectIdentifier("parameter name expected");
   Function& owner_function = Function::Handle();
   LocalScope* owner_scope;
   intptr_t param_index;
   if (!IsFormalParameter(*ident, &owner_function, &owner_scope, &param_index)) {
     ErrorMsg(ident_pos, "formal parameter name expected");
   }
   if (param_index < owner_function.num_fixed_parameters()) {
     // The formal parameter is not optional, therefore the corresponding
     // argument is always passed and defined.
-    return new LiteralNode(test_pos, Bool::ZoneHandle(Bool::True()));
+    return new LiteralNode(test_pos, Bool::True());
   }
   char name[64];
   OS::SNPrint(name, 64, "%s_%"Pd"",
               Symbols::Name(Symbols::kSavedArgDescVarPrefixId),
               owner_function.token_pos());
   const String& saved_args_desc_name = String::ZoneHandle(Symbols::New(name));
   LocalVariable* saved_args_desc_var = LookupLocalScope(saved_args_desc_name);
   if (saved_args_desc_var == NULL) {
     ASSERT(owner_scope != NULL);
     saved_args_desc_var =
@@ skipping 73 matching lines @@
     if (local == NULL) {
       ErrorMsg("receiver 'this' is not in scope");
     }
     primary = new LoadLocalNode(TokenPos(), local);
     ConsumeToken();
   } else if (CurrentToken() == Token::kINTEGER) {
     const Integer& literal = Integer::ZoneHandle(CurrentIntegerLiteral());
     primary = new LiteralNode(TokenPos(), literal);
     ConsumeToken();
   } else if (CurrentToken() == Token::kTRUE) {
-    primary = new LiteralNode(TokenPos(), Bool::ZoneHandle(Bool::True()));
+    primary = new LiteralNode(TokenPos(), Bool::True());
     ConsumeToken();
   } else if (CurrentToken() == Token::kFALSE) {
-    primary = new LiteralNode(TokenPos(), Bool::ZoneHandle(Bool::False()));
+    primary = new LiteralNode(TokenPos(), Bool::False());
     ConsumeToken();
   } else if (CurrentToken() == Token::kNULL) {
     primary = new LiteralNode(TokenPos(), Instance::ZoneHandle());
     ConsumeToken();
   } else if (CurrentToken() == Token::kLPAREN) {
     ConsumeToken();
     const bool saved_mode = SetAllowFunctionLiterals(true);
     primary = ParseExpr(kAllowConst, kConsumeCascades);
     SetAllowFunctionLiterals(saved_mode);
     ExpectToken(Token::kRPAREN);
@@ skipping 363 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart