Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Issue 11745015: Update references to the extension messaging APIs to point to the "runtime" (Closed)

Created:
7 years, 11 months ago by not at google - send to devlin
Modified:
7 years, 11 months ago
CC:
chromium-reviews, Matt Perry
Visibility:
Public.

Description

Update references to the extension messaging APIs and lastError to point to the "runtime" namespace rather than "extension" in docs and samples. R=asargent@chromium.org TBR=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175527

Patch Set 1 #

Total comments: 3

Patch Set 2 : fullstops #

Patch Set 3 : rebase? #

Total comments: 3

Patch Set 4 : argghghghg run dos2unix #

Patch Set 5 : bah I give up #

Patch Set 6 : fix things #

Patch Set 7 : fix copyright headers #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -417 lines) Patch
M chrome/browser/extensions/api/downloads/downloads_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_copy_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/bluetooth.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/context_menus.json View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/cookies.json View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension.json View 5 chunks +0 lines, -190 lines 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/file_browser_private.json View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/input_ime.json View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/tts.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/webstore_private.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/debugger/live-headers/background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/debugger/pause-resume/background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/devtools/audits/broken-links/devtools.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/eventPage/basic/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/eventPage/basic/content.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/infobars/sandwichbar/contentscript.js View 1 2 3 4 5 6 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/messaging/timer/page.js View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/speechInput/basic/background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/benchmark/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/benchmark/script.js View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/catifier/event_page.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/email_this_page/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/email_this_page/content_script.js View 1 2 3 4 5 6 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/js/chrome_stubs.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/js/main.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/js/plugin_settings.js View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/talking_alarm_clock/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/talking_alarm_clock/popup.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/ttsdemo/ttsdemo.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/content_scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/manifestVersion.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/whats_new.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/experimental_speechInput.html View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/privacy.html View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/tts.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 1 2 3 4 5 1 chunk +17 lines, -10 lines 0 comments Download
M chrome/renderer/resources/extensions/miscellaneous_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/runtime_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/devtools/extensions/devtools_messaging/background.js View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/data/devtools/extensions/devtools_messaging/devtools.js View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/README.txt View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/bypass_page_csp/a.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/bypass_page_csp/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/isolated_world1/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/isolated_world1/c.js View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/isolated_world2/a.js View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/isolated_world2/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/basics/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/debugger/background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/executescript/frame_after_load/test.js View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/executescript/in_frame/script.js View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/executescript/in_frame/test.js View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/executescript/navigation_race/test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_component/main.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_component/remote.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler/tab.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler_lazy_background/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler_lazy_background/tab.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler_write/tab.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/incognito/apis/background.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/incognito/split/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/input/test.js View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/messaging/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/messaging/content.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/messaging/connect/page.js View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/test/data/extensions/api_test/messaging/connect/test.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/messaging/connect_external/test.js View 1 2 3 4 5 1 chunk +17 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/messaging/connect_panel/panel.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/messaging/connect_panel/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/native_messaging/test.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/page_capture/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/permissions/optional_deny/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/speech_input/recognition/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/speech_input/recognition_error/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/speech_input/start_error/test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/speech_input/start_stop/test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test_race.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/connect/echo.js View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webrequest/permissionless/rules.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/browsertest/crash_25562/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/browsertest/crash_25562/script.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/browsertest/last_error/bg.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/browsertest/title_localized_pa/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/browsertest/title_localized_pa/script.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/context_menus/frames/test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/context_menus/incognito/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/context_menus/long_title/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/context_menus/patterns/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/context_menus/separators/common.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/context_menus/simple/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/context_menus/target_urls/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/page.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/management/launch_app/test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/management/uninstall_extension/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/uitest/window_open/newtab.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/panels/context_menu/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/panels/context_menu2/test.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/permissions.json View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/test/tabs.json View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/page_cycler/webpagereplay/extension/background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/page_cycler/webpagereplay/extension/start.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
not at google - send to devlin
I noticed that presubmit tests were failing on resolving doc links to extension.sendMessage (and a ...
7 years, 11 months ago (2013-01-03 18:10:56 UTC) #1
asargent_no_longer_on_chrome
LGTM w/ one needed fix in chrome/test/data/extensions/api_test/stubs/content_script.js https://codereview.chromium.org/11745015/diff/1/chrome/common/extensions/api/extension.json File chrome/common/extensions/api/extension.json (left): https://codereview.chromium.org/11745015/diff/1/chrome/common/extensions/api/extension.json#oldcode19 chrome/common/extensions/api/extension.json:19: }, On ...
7 years, 11 months ago (2013-01-03 22:42:27 UTC) #2
not at google - send to devlin
Ok, finally got the trybots working (they weren't liking some DOS file endings, ugh) so ...
7 years, 11 months ago (2013-01-04 22:22:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/11745015/24007
7 years, 11 months ago (2013-01-07 16:47:28 UTC) #4
commit-bot: I haz the power
Presubmit check for 11745015-24007 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-07 16:48:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/11745015/17006
7 years, 11 months ago (2013-01-07 17:47:05 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 20:05:13 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 01:39:50 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698