Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 11745003: GTTF: dump registers on crash on 64-bit Linux (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.
Modified:
7 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

GTTF: dump registers on crash on 64-bit Linux BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176110

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -29 lines) Patch
M base/debug/stack_trace.h View 1 chunk +5 lines, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 6 chunks +56 lines, -8 lines 4 comments Download
M base/debug/stack_trace_unittest.cc View 2 chunks +37 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
7 years, 11 months ago (2013-01-02 19:04:25 UTC) #1
jar (doing other things)
https://codereview.chromium.org/11745003/diff/1/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/11745003/diff/1/base/debug/stack_trace_posix.cc#newcode199 base/debug/stack_trace_posix.cc:199: { " r8: ", context->uc_mcontext.gregs[REG_R8] }, Question: Are all ...
7 years, 11 months ago (2013-01-04 20:57:36 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/11745003/diff/1/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/11745003/diff/1/base/debug/stack_trace_posix.cc#newcode199 base/debug/stack_trace_posix.cc:199: { " r8: ", context->uc_mcontext.gregs[REG_R8] }, On 2013/01/04 20:57:36, ...
7 years, 11 months ago (2013-01-04 21:53:22 UTC) #3
jar (doing other things)
https://codereview.chromium.org/11745003/diff/1/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/11745003/diff/1/base/debug/stack_trace_posix.cc#newcode131 base/debug/stack_trace_posix.cc:131: OutputPointer(trace[i], handler); Why did you change the order of ...
7 years, 11 months ago (2013-01-09 19:04:25 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/11745003/diff/1/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/11745003/diff/1/base/debug/stack_trace_posix.cc#newcode131 base/debug/stack_trace_posix.cc:131: OutputPointer(trace[i], handler); On 2013/01/09 19:04:25, jar wrote: > Why ...
7 years, 11 months ago (2013-01-09 19:08:25 UTC) #5
jar (doing other things)
7 years, 11 months ago (2013-01-10 04:55:05 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698