Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(167)

Issue 1174493002: DevTools: rename inspectedWindow to inspectedGlobalObject in InjectedScriptSource.js (Closed)

Created:
4 years, 10 months ago by yurys
Modified:
4 years, 10 months ago
Reviewers:
caseq, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: rename inspectedWindow to inspectedGlobalObject in InjectedScriptSource.js The variable may reference either Window in case of Page inspection or WorkerGlobalScope in case of workers. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M Source/core/inspector/InjectedScriptSource.js View 21 chunks +32 lines, -32 lines 0 comments Download
M Source/core/inspector/injected_script_externs.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
yurys
4 years, 10 months ago (2015-06-09 09:54:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174493002/1
4 years, 10 months ago (2015-06-09 09:54:38 UTC) #4
caseq
lgtm
4 years, 10 months ago (2015-06-09 10:01:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174493002/1
4 years, 10 months ago (2015-06-09 10:05:11 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 11:11:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196754

Powered by Google App Engine
This is Rietveld 408576698