Issue 1174473002: Componentization: make InspectorTaskRunner visible for blink_web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1174473002: Componentization: make InspectorTaskRunner visible for blink_web. (Closed)

Created:
4 years, 10 months ago by tasak

Modified:
4 years, 10 months ago

Reviewers:
haraken, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Componentization: make InspectorTaskRunner visible for blink_web. Need to make InspectorTaskRunner visible, Source/web/WebDevToolsAgentImpl.cpp uses the class. c.f. Source/web/WebDevToolsAgentImpl.cpp:637: error: undefined reference to 'blink::InspectorTaskRunner::runPendingTasks()' BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196830

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/core/inspector/InspectorTaskRunner.h	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174473002/1

4 years, 10 months ago (2015-06-10 04:56:46 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-10 05:00:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196830

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages