Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: Source/core/loader/ImageLoader.h

Issue 1174463003: Oilpan: Disable lazy seeping for ImageLoaders (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/loader/ImageLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/ImageLoader.h
diff --git a/Source/core/loader/ImageLoader.h b/Source/core/loader/ImageLoader.h
index c7588f8a37224a4dc50f78bc019686e2927a3710..a938d7d01abc7f9d0956cba3828298aadb23014b 100644
--- a/Source/core/loader/ImageLoader.h
+++ b/Source/core/loader/ImageLoader.h
@@ -62,6 +62,13 @@ class CORE_EXPORT ImageLoader : public NoBaseWillBeGarbageCollectedFinalized<Ima
public:
explicit ImageLoader(Element*);
virtual ~ImageLoader();
+
+ // We must run the destructor in the eager sweeping phase and call
+ // m_image->removeClient(this). Otherwise, the ImageResource can invoke
+ // didAddClient() for the ImageLoader that is about to die in the current
+ // lazy sweeping, and the didAddClient() can access on-heap objects that
+ // have already been finalized in the current lazy sweeping.
+ EAGERLY_FINALIZE();
DECLARE_TRACE();
enum UpdateFromElementBehavior {
« no previous file with comments | « no previous file | Source/core/loader/ImageLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698