Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: tests/html/mutationobserver_test.dart

Issue 117443003: Update comment to mention Blink bug (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/mutationobserver_test.dart
diff --git a/tests/html/mutationobserver_test.dart b/tests/html/mutationobserver_test.dart
index a77a26b250b3f5ef669a005017b7b4a2da7c4bb4..582f0844ebfa432f40ba11bb2a7aa8d4c1733042 100644
--- a/tests/html/mutationobserver_test.dart
+++ b/tests/html/mutationobserver_test.dart
@@ -7,14 +7,10 @@ import '../../pkg/unittest/lib/unittest.dart';
import '../../pkg/unittest/lib/html_individual_config.dart';
import 'dart:html';
-// MutationObservers sometimes do not fire if the node being observed is GCed
+// Due to https://code.google.com/p/chromium/issues/detail?id=329103
+// mutationObservers sometimes do not fire if the node being observed is GCed
// so we keep around references to all nodes we have created mutation
-// observers for. As a side note, this behavior only manifests in content_shell
-// and not chrome and the behavior goes away in content_shell if the flag
-// -js-flags="--gc_global" is passed to content_shell. Note: the gc behavior
-// only has been detected when running dart2js but could equally reasonably
-// impact the dartvm as well unless it is specified that mutation events must
-// be delivered even if the object the events are for has already been GCed.
+// observers for.
var keepAlive = [];
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698