Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 1174413002: TreatReturnedNullStringAs=undefined removed from XSLTProcessor.idl (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
haraken, philipj_slow
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

TreatReturnedNullStringAs removed from XSLTProcessor.idl XSLTProcessor::getParameter() returns value hold in hashmap m_parameters, the value it hold are set via setParameters() and is set via JS bindings. The value of m_parameters key if reset or removed it returns a null value. getParmeter() is not based on W3C API but is compatible solution with Gecko, with behaviour defined as Gets a parameter if previously set by setParameter. Returns null otherwise. Test in xslt-processor.html exhibits that value when is not set, reset or clear it returns in getParameter a null value for the key. BUG=497982 R=philipj, haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197109

Patch Set 1 #

Patch Set 2 : Updated LayoutTests #

Patch Set 3 : Return nullable value for getParameter instead of null string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M LayoutTests/fast/xsl/xslt-processor.html View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/xml/XSLTProcessor.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174413002/1
5 years, 6 months ago (2015-06-11 09:14:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174413002/20001
5 years, 6 months ago (2015-06-12 13:40:37 UTC) #5
Habib Virji
please take a look.
5 years, 6 months ago (2015-06-12 14:27:53 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-12 15:00:12 UTC) #8
philipj_slow
For the cases where the behavior has changed, can you also document the behavior of ...
5 years, 6 months ago (2015-06-12 19:26:06 UTC) #9
philipj_slow
I just took a peek at Gecko and what this API actually does. This shape ...
5 years, 6 months ago (2015-06-12 19:41:17 UTC) #10
philipj_slow
I couldn't find a spec for this, but apparently it's a Mozilla thing: https://lists.w3.org/Archives/Public/public-webapi/2006Mar/0021.html Here ...
5 years, 6 months ago (2015-06-12 19:44:37 UTC) #11
Habib Virji
Thanks Philip for looking and also having a look in Gecko code. I have updated ...
5 years, 6 months ago (2015-06-15 08:37:37 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174413002/40001
5 years, 6 months ago (2015-06-15 08:37:42 UTC) #14
philipj_slow
lgtm Awesome!
5 years, 6 months ago (2015-06-15 10:09:44 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 10:40:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174413002/40001
5 years, 6 months ago (2015-06-15 11:24:03 UTC) #19
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 11:28:13 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197109

Powered by Google App Engine
This is Rietveld 408576698