Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11744030: Try 2 [Media Gallery] Move chrome/browser/media_transfer_protocol code to src/device. (Closed)

Created:
7 years, 11 months ago by kmadhusu
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Try 2 [Media Gallery] Move chrome/browser/media_transfer_protocol code to src/device. BUG=156929 TEST=none Original CL: https://chromiumcodereview.appspot.com/11744014 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175150

Patch Set 1 #

Patch Set 2 : Fixed gyp dependencies. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -1370 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_gallery/linux/mtp_device_delegate_impl_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/linux/mtp_device_object_enumerator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/linux/mtp_device_operations_utils.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/media_gallery/linux/mtp_device_operations_utils.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/media_gallery/linux/mtp_get_file_info_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/linux/mtp_get_file_info_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/linux/mtp_open_storage_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/linux/mtp_read_directory_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/linux/mtp_read_directory_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/linux/mtp_read_file_worker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_gallery/linux/mtp_recursive_device_object_enumerator.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/media_transfer_protocol/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/media_transfer_protocol/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/media_transfer_protocol/media_transfer_protocol_daemon_client.h View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/browser/media_transfer_protocol/media_transfer_protocol_daemon_client.cc View 1 chunk +0 lines, -489 lines 0 comments Download
D chrome/browser/media_transfer_protocol/media_transfer_protocol_manager.h View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/browser/media_transfer_protocol/media_transfer_protocol_manager.cc View 1 chunk +0 lines, -453 lines 0 comments Download
M chrome/browser/system_monitor/media_transfer_protocol_device_observer_linux.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/system_monitor/media_transfer_protocol_device_observer_linux.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +3 lines, -41 lines 1 comment Download
M chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M device/device.gyp View 1 chunk +49 lines, -0 lines 0 comments Download
A device/media_transfer_protocol/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
A + device/media_transfer_protocol/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/media_transfer_protocol/media_transfer_protocol_daemon_client.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + device/media_transfer_protocol/media_transfer_protocol_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + device/media_transfer_protocol/media_transfer_protocol_manager.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/mtpd/mtpd.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kmadhusu
rsleevi, thestig: Added explicit dependencies to protobufs in chrome_browser.gypi. PTAL. Thanks. https://codereview.chromium.org/11744030/diff/2001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): ...
7 years, 11 months ago (2013-01-04 02:14:22 UTC) #1
Lei Zhang
lgtm
7 years, 11 months ago (2013-01-04 02:30:35 UTC) #2
Ryan Sleevi
lgtm
7 years, 11 months ago (2013-01-04 02:32:54 UTC) #3
kmadhusu
gdk@: Can you please do the OWNER's check again? (Previous CL was reverted because of ...
7 years, 11 months ago (2013-01-04 02:33:45 UTC) #4
Garret Kelly
owners lgtm
7 years, 11 months ago (2013-01-04 15:59:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/11744030/2001
7 years, 11 months ago (2013-01-04 16:46:33 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 18:06:07 UTC) #7
Message was sent while issue was closed. 
Change committed as 175150

Powered by Google App Engine
This is Rietveld 408576698