Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issue 11744028: Prepare to use generated shim headers for FLAC (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.
Modified:
7 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Visibility:
Public.

Description

Prepare to use generated shim headers for FLAC This will require a DEPS roll and corresponding changes to chromium-side .cc files. BUG=165264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
D flac.h View 1 chunk +0 lines, -18 lines 0 comments Download
M flac.gyp View 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
7 years, 11 months ago (2013-01-04 00:32:22 UTC) #1
DaleCurtis
Hmm, I don't completely follow the process here. Your changes don't seem to be a ...
7 years, 11 months ago (2013-01-04 02:15:30 UTC) #2
Paweł Hajdan Jr.
On 2013/01/04 02:15:30, DaleCurtis wrote: > Hmm, I don't completely follow the process here. Your ...
7 years, 11 months ago (2013-01-04 02:36:47 UTC) #3
DaleCurtis
7 years, 11 months ago (2013-01-04 22:00:11 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698