Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 11744027: Extension docs server: assume everything is "trunk" if the branch can't be (Closed)

Created:
7 years, 11 months ago by not at google - send to devlin
Modified:
7 years, 11 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews
Visibility:
Public.

Description

Extension docs server: assume everything is "trunk" if the branch can't be determined (e.g. omahaproxy down). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175068

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/common/extensions/docs/server2/branch_utility.py View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
7 years, 11 months ago (2013-01-04 00:31:07 UTC) #1
Yoyo Zhou
LGTM
7 years, 11 months ago (2013-01-04 00:33:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/11744027/3001
7 years, 11 months ago (2013-01-04 00:49:08 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 00:50:15 UTC) #4
Message was sent while issue was closed.
Presubmit check for 11744027-3001 failed and returned exit status 1.


*----------------------------------*
| integration_test.py has failures |
*----------------------------------*
testCron (__main__.IntegrationTest)
Traceback (most recent call last):
  File "docs/server2/integration_test.py", line 127, in testCron
    Handler(request, response, local_path=BASE_PATH).get()
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 368, in get
    self._HandleCron(path)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 289, in _HandleCron
    channel)
  File
"/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/handler.py",
line 244, in _Render
    logging.error('Error rendering %s: %s' % (path, str(e)))
AssertionError: Error rendering trunk/extensions/tabs.html: $ref
extension.onConnect could not be resolved.

testAllPublicTemplates (__main__.IntegrationTest)
Traceback (most recent call last):
  File "docs/server2/integration_test.py", line 103, in testAllPublicTemplates
    self._RunPublicTemplatesTest()
  File "docs/server2/integration_test.py", line 96, in _RunPublicTemplatesTest
    self.fail('\n'.join(failures))
AssertionError: Error rendering extensions/tabs.html: $ref extension.onConnect
could not be resolved.
Error rendering extensions/whats_new.html: $ref extension.sendMessage could not
be resolved.
Error rendering extensions/manifestVersion.html: $ref extension.Port could not
be resolved.
Error rendering apps/whats_new.html: $ref extension.sendMessage could not be
resolved.
Error rendering apps/manifestVersion.html: $ref extension.Port could not be
resolved.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
IntegrationTest failed!

Presubmit checks took 64.8s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698