Delete code / cleanup in GpuProcessHost.

Delete code / cleanup in GpuProcessHost.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175076

[apatrick_chromium, 2013-01-03 22:48:26]

PTAL

https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
File content/browser/gpu/gpu_process_host.cc (left):

https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
content/browser/gpu/gpu_process_host.cc:484: // On Windows the GPU thread needs
to pump the compositor child window's
This thread no longer creates a child window so an IO message loop is okay.

https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
content/browser/gpu/gpu_process_host.cc:699: if (route_id == MSG_ROUTING_NONE)
Control statement is redundant:

void GpuProcessHost::CreateCommandBufferError(	
    const CreateCommandBufferCallback& callback, int32 route_id) {	
  callback.Run(route_id);	
}

[Zhenyao Mo, 2013-01-03 23:04:30]

LGTM

https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
content/browser/gpu/gpu_process_host.cc:64: GpuProcessHost *g_gpu_process_hosts[
style nit: should be GpuProcessHost* (no space between)

https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
content/browser/gpu/gpu_process_host.cc:734: NOTREACHED();
nit: Is this default branch necessary?  Without it, compiler will check all the
enums in a switch statement, so likely catch unhandled ones at compile time
instead of a runtime NOTREACHED().

[apatrick_chromium, 2013-01-03 23:12:39]

https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
content/browser/gpu/gpu_process_host.cc:734: NOTREACHED();
On 2013/01/03 23:04:30, Zhenyao Mo wrote:
> nit: Is this default branch necessary?  Without it, compiler will check all
the
> enums in a switch statement, so likely catch unhandled ones at compile time
> instead of a runtime NOTREACHED().

In C++, an enum value is not limited to the members of the enum type. e.g.
"reason" could equal 123 here as far as the compiler is concerned and some
compilers will emit a warning.

[Zhenyao Mo, 2013-01-03 23:15:32]

On 2013/01/03 23:12:39, apatrick_chromium wrote:
>
https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
> File content/browser/gpu/gpu_process_host.cc (right):
> 
>
https://codereview.chromium.org/11744008/diff/6007/content/browser/gpu/gpu_pr...
> content/browser/gpu/gpu_process_host.cc:734: NOTREACHED();
> On 2013/01/03 23:04:30, Zhenyao Mo wrote:
> > nit: Is this default branch necessary?  Without it, compiler will check all
> the
> > enums in a switch statement, so likely catch unhandled ones at compile time
> > instead of a runtime NOTREACHED().
> 
> In C++, an enum value is not limited to the members of the enum type. e.g.
> "reason" could equal 123 here as far as the compiler is concerned and some
> compilers will emit a warning.

I see.  Thanks for explaining this to me.

[commit-bot: I haz the power, 2013-01-03 23:21:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11744008/13001

[commit-bot: I haz the power, 2013-01-03 23:33:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/11744008/7004

[commit-bot: I haz the power, 2013-01-04 01:49:47]

Change committed as 175076