Issue 11744007: [telemetry] Cleaning up Forwarders and Ports.

Issue 11744007: [telemetry] Cleaning up Forwarders and Ports. (Closed)

Created:
7 years, 11 months ago by hartmanng

Modified:
7 years, 11 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org, nduca

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Cleaning up Forwarders and Ports. This is the first clean-up patch for https://codereview.chromium.org/11348217/#msg10. I'll have at least one more clean-up patch (to fix the globals in webpagereplay.py), then I'll finish up with removing the flake. BUG=157459 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174969

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -28 lines)			Patch
M	tools/telemetry/telemetry/adb_commands.py	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/android_browser_backend.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/browser_backend.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/cros_browser_backend.py	View	1	3 chunks	+24 lines, -16 lines	0 comments	Download
M	tools/telemetry/telemetry/desktop_browser_backend.py	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/temporary_http_server.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/util.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/wpr_server.py	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tonyg

On 2013/01/02 21:47:36, hartmanng wrote: > Please take a look lgtm

7 years, 11 months ago (2013-01-02 22:46:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11744007/2021

7 years, 11 months ago (2013-01-03 14:12:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11744007/2021

7 years, 11 months ago (2013-01-03 14:13:19 UTC) #4

tonyg

7 years, 11 months ago (2013-01-03 23:04:13 UTC) #6

Message was sent while issue was closed.

On 2013/01/03 16:28:17, I haz the power (commit-bot) wrote:
> Change committed as 174969

It looks like this broke android. See:
http://build.chromium.org/p/chromium.perf/builders/Android%20GN/builds/2100/s...

Expand Messages | Collapse Messages