Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: chrome/installer/util/logging_installer.cc

Issue 117433002: Remove installation of Chrome Frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: indentation fix and new unittest Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/logging_installer.cc
diff --git a/chrome/installer/util/logging_installer.cc b/chrome/installer/util/logging_installer.cc
index 3ac60b365246e2af737583975e92a7e2eb5db1c3..766af8d57e709d711f5f837b1fce6f91248f5679 100644
--- a/chrome/installer/util/logging_installer.cc
+++ b/chrome/installer/util/logging_installer.cc
@@ -118,15 +118,15 @@ base::FilePath GetLogFilePath(const installer::MasterPreferences& prefs) {
return base::FilePath(UTF8ToWide(path));
}
- std::wstring log_filename = prefs.install_chrome_frame() ?
- L"chrome_frame_installer.log" : L"chrome_installer.log";
+ static const base::FilePath::CharType kLogFilename[] =
+ FILE_PATH_LITERAL("chrome_installer.log");
base::FilePath log_path;
if (PathService::Get(base::DIR_TEMP, &log_path)) {
- log_path = log_path.Append(log_filename);
+ log_path = log_path.Append(kLogFilename);
gab 2013/12/19 01:18:31 Rename log_path -> tmp_path; and return tmp_path.A
return log_path;
} else {
- return base::FilePath(log_filename);
+ return base::FilePath(kLogFilename);
}
}

Powered by Google App Engine
This is Rietveld 408576698