Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/installer/util/master_preferences.cc

Issue 117433002: Remove installation of Chrome Frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: typo fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/master_preferences.h ('k') | chrome/installer/util/master_preferences_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/master_preferences.cc
diff --git a/chrome/installer/util/master_preferences.cc b/chrome/installer/util/master_preferences.cc
index cf2830055579d97f3ec25287dd061e7ebada768d..76b544ff61985a1d358140ee8ba174a8b7b48fd1 100644
--- a/chrome/installer/util/master_preferences.cc
+++ b/chrome/installer/util/master_preferences.cc
@@ -75,7 +75,6 @@ MasterPreferences::MasterPreferences() : distribution_(NULL),
preferences_read_from_file_(false),
chrome_(true),
chrome_app_launcher_(false),
- chrome_frame_(false),
multi_install_(false) {
InitializeFromCommandLine(*CommandLine::ForCurrentProcess());
}
@@ -85,7 +84,6 @@ MasterPreferences::MasterPreferences(const CommandLine& cmd_line)
preferences_read_from_file_(false),
chrome_(true),
chrome_app_launcher_(false),
- chrome_frame_(false),
multi_install_(false) {
InitializeFromCommandLine(cmd_line);
}
@@ -95,7 +93,6 @@ MasterPreferences::MasterPreferences(const base::FilePath& prefs_path)
preferences_read_from_file_(false),
chrome_(true),
chrome_app_launcher_(false),
- chrome_frame_(false),
multi_install_(false) {
std::string json_data;
// Failure to read the file is ignored as |json_data| will be the empty string
@@ -114,7 +111,6 @@ MasterPreferences::MasterPreferences(const std::string& prefs)
preferences_read_from_file_(false),
chrome_(true),
chrome_app_launcher_(false),
- chrome_frame_(false),
multi_install_(false) {
InitializeFromString(prefs);
}
@@ -149,8 +145,6 @@ void MasterPreferences::InitializeFromCommandLine(const CommandLine& cmd_line) {
installer::master_preferences::kChromeAppLauncher },
{ installer::switches::kChrome,
installer::master_preferences::kChrome },
- { installer::switches::kChromeFrame,
- installer::master_preferences::kChromeFrame },
{ installer::switches::kDisableLogging,
installer::master_preferences::kDisableLogging },
{ installer::switches::kMsi,
@@ -231,12 +225,10 @@ bool MasterPreferences::InitializeFromString(const std::string& json_data) {
void MasterPreferences::InitializeProductFlags() {
// Make sure we start out with the correct defaults.
multi_install_ = false;
- chrome_frame_ = false;
chrome_app_launcher_ = false;
chrome_ = true;
GetBool(installer::master_preferences::kMultiInstall, &multi_install_);
- GetBool(installer::master_preferences::kChromeFrame, &chrome_frame_);
GetBool(installer::master_preferences::kChromeAppLauncher,
&chrome_app_launcher_);
@@ -250,17 +242,12 @@ void MasterPreferences::InitializeProductFlags() {
// When multi-install is specified, the checks are pretty simple (in theory):
// In order to be installed/uninstalled, each product must have its switch
// present on the command line.
- // Before multi-install was introduced however, we only supported installing
- // two products, Chrome and Chrome Frame. For the time being we need to
- // continue to support this mode where multi-install is not set.
- // So, when multi-install is not set, we continue to support mutually
- // exclusive installation of Chrome and Chrome Frame.
+ // When multi-install is not set, operate on Chrome.
if (multi_install_) {
if (!GetBool(installer::master_preferences::kChrome, &chrome_))
chrome_ = false;
} else {
- // If chrome-frame is on the command line however, we only install CF.
- chrome_ = !chrome_frame_;
+ chrome_ = true;
}
}
« no previous file with comments | « chrome/installer/util/master_preferences.h ('k') | chrome/installer/util/master_preferences_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698