Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1174323002: [Patch 5 of 6] Split out the site_isolation_policy files (Closed)

Created:
5 years, 6 months ago by ncarter (slow)
Modified:
5 years, 6 months ago
Reviewers:
Charlie Reis, alexmos
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename_policy_to_sniffer3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL moves classes (refactored in situ, in previous patches) into appropriately named files. New classes are CrossSiteDocumentClassifier and SiteIsolationStatsGatherer. CrossSiteDocumentClassifier is moved to content/common so we can use it from the browser process. No files should be left now with the name site_isolation_policy*.* BUG=481066 Committed: https://crrev.com/e7cd12af5b21f71f1e8dc8a2f5dfb476d44afa0b Cr-Commit-Position: refs/heads/master@{#334779}

Patch Set 1 #

Patch Set 2 : Set proper base branch. #

Patch Set 3 : Pull #

Total comments: 4

Patch Set 4 : Sync #

Patch Set 5 : 2015 #

Patch Set 6 : Style fix. #

Patch Set 7 : Add crbug link. #

Patch Set 8 : Re-upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1718 lines) Patch
M content/child/resource_dispatcher.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D content/child/site_isolation_policy.h View 1 2 3 1 chunk +0 lines, -154 lines 0 comments Download
D content/child/site_isolation_policy.cc View 1 2 3 1 chunk +0 lines, -494 lines 0 comments Download
D content/child/site_isolation_policy_browsertest.cc View 1 chunk +0 lines, -250 lines 0 comments Download
D content/child/site_isolation_policy_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download
A + content/child/site_isolation_stats_gatherer.h View 1 2 3 5 chunks +9 lines, -63 lines 0 comments Download
A + content/child/site_isolation_stats_gatherer.cc View 1 2 3 5 chunks +5 lines, -242 lines 0 comments Download
A + content/child/site_isolation_stats_gatherer_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + content/child/site_isolation_stats_gatherer_unittest.cc View 1 chunk +16 lines, -15 lines 0 comments Download
A + content/common/cross_site_document_classifier.h View 1 2 3 3 chunks +5 lines, -90 lines 0 comments Download
A + content/common/cross_site_document_classifier.cc View 1 2 3 4 5 chunks +4 lines, -245 lines 0 comments Download
A + content/common/cross_site_document_classifier_unittest.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/render_process_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
ncarter (slow)
alexmos: this is the last refactor step, just renaming/splitting files.
5 years, 6 months ago (2015-06-11 06:31:34 UTC) #2
alexmos
LGTM https://codereview.chromium.org/1174323002/diff/40001/content/child/site_isolation_stats_gatherer_browsertest.cc File content/child/site_isolation_stats_gatherer_browsertest.cc (right): https://codereview.chromium.org/1174323002/diff/40001/content/child/site_isolation_stats_gatherer_browsertest.cc#newcode1 content/child/site_isolation_stats_gatherer_browsertest.cc:1: // Copyright 2013 The Chromium Authors. All rights ...
5 years, 6 months ago (2015-06-13 00:27:04 UTC) #3
ncarter (slow)
creis@chromium.org: Please review changes in content/ https://codereview.chromium.org/1174323002/diff/40001/content/child/site_isolation_stats_gatherer_browsertest.cc File content/child/site_isolation_stats_gatherer_browsertest.cc (right): https://codereview.chromium.org/1174323002/diff/40001/content/child/site_isolation_stats_gatherer_browsertest.cc#newcode1 content/child/site_isolation_stats_gatherer_browsertest.cc:1: // Copyright 2013 ...
5 years, 6 months ago (2015-06-16 22:43:23 UTC) #5
Charlie Reis
LGTM. Do any GN files need updating? (I haven't had to deal with that yet ...
5 years, 6 months ago (2015-06-16 23:22:07 UTC) #6
ncarter (slow)
On 2015/06/16 23:22:07, Charlie Reis wrote: > LGTM. Do any GN files need updating? (I ...
5 years, 6 months ago (2015-06-17 03:59:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174323002/140001
5 years, 6 months ago (2015-06-17 05:44:18 UTC) #10
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 6 months ago (2015-06-17 06:48:48 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 06:49:37 UTC) #12
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/e7cd12af5b21f71f1e8dc8a2f5dfb476d44afa0b
Cr-Commit-Position: refs/heads/master@{#334779}

Powered by Google App Engine
This is Rietveld 408576698