Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: runtime/vm/report_test.cc

Issue 1174313002: Allow setting break-on-exceptions option over the service protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/report_test.cc
diff --git a/runtime/vm/report_test.cc b/runtime/vm/report_test.cc
index 24a182594a2c9528072b1494a8b2b36caa631955..73f21084663dadca2d40078e5eb58da653abd6c5 100644
--- a/runtime/vm/report_test.cc
+++ b/runtime/vm/report_test.cc
@@ -15,7 +15,7 @@ TEST_CASE(TraceJSWarning) {
const String& url = String::Handle(isolate, String::New("Plug"));
const String& source = String::Handle(isolate, String::New("240 100"));
const Script& script = Script::Handle(isolate,
- Script::New(url, source, RawScript::kScriptTag));
+ Script::New(url, source, RawScript::kEvaluateTag));
script.Tokenize(String::Handle(String::New("")));
{
const intptr_t token_pos = 0;
@@ -29,10 +29,11 @@ TEST_CASE(TraceJSWarning) {
js.ToCString());
// Skip time.
EXPECT_SUBSTRING("\"message\":{\"type\":\"JSCompatibilityWarning\","
- "\"script\":{\"type\":\"@Script\",\"fixedId\":true,"
- "\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
- "\"uri\":\"Plug\","
- "\"_kind\":\"script\"},\"tokenPos\":0,"
+ "\"script\":{\"type\":\"@Script\"",
+ js.ToCString());
+ // Skip object ring id.
+ EXPECT_SUBSTRING("\"uri\":\"Plug\","
+ "\"_kind\":\"evaluate\"},\"tokenPos\":0,"
"\"message\":{\"type\":\"@Instance\"",
js.ToCString());
// Skip private _OneByteString.
@@ -47,10 +48,11 @@ TEST_CASE(TraceJSWarning) {
}
EXPECT_EQ(2, trace_buffer->Length());
EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
- "\"@Script\",\"fixedId\":true,"
- "\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
- "\"uri\":\"Plug\","
- "\"_kind\":\"script\"},\"tokenPos\":0,"
+ "\"@Script\"",
+ trace_buffer->At(0)->message);
+ // Skip object ring id.
+ EXPECT_SUBSTRING("\"uri\":\"Plug\","
+ "\"_kind\":\"evaluate\"},\"tokenPos\":0,"
"\"message\":{\"type\":\"@Instance\"",
trace_buffer->At(0)->message);
// Skip private _OneByteString.
@@ -58,10 +60,11 @@ TEST_CASE(TraceJSWarning) {
trace_buffer->At(0)->message);
EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
- "\"@Script\",\"fixedId\":true,"
- "\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
- "\"uri\":\"Plug\","
- "\"_kind\":\"script\"},\"tokenPos\":1,"
+ "\"@Script\"",
+ trace_buffer->At(1)->message);
+ // Skip object ring id.
+ EXPECT_SUBSTRING("\"uri\":\"Plug\","
+ "\"_kind\":\"evaluate\"},\"tokenPos\":1,"
"\"message\":{\"type\":\"@Instance\"",
trace_buffer->At(1)->message);
// Skip private _OneByteString.
« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698