Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: runtime/vm/debugger.cc

Issue 1174313002: Allow setting break-on-exceptions option over the service protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 939dafdd8fdfab7866e6af741d3633fe4051c6e6..376f4a576a3bdfabf334d224a3e505ba378559a2 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -480,6 +480,24 @@ void Debugger::PrintBreakpointsToJSONArray(JSONArray* jsarr) const {
}
+void Debugger::PrintSettingsToJSONObject(JSONObject* jsobj) const {
+ // This won't cut it when we support filtering by class, etc.
+ switch (GetExceptionPauseInfo()) {
+ case kNoPauseOnExceptions:
+ jsobj->AddProperty("_exceptions", "none");
+ break;
+ case kPauseOnAllExceptions:
+ jsobj->AddProperty("_exceptions", "all");
+ break;
+ case kPauseOnUnhandledExceptions:
+ jsobj->AddProperty("_exceptions", "unhandled");
+ break;
+ default:
+ UNREACHABLE();
+ }
+}
+
+
RawString* ActivationFrame::QualifiedFunctionName() {
return String::New(Debugger::QualifiedFunctionName(function()));
}
@@ -1507,7 +1525,7 @@ void Debugger::SetExceptionPauseInfo(Dart_ExceptionPauseInfo pause_info) {
}
-Dart_ExceptionPauseInfo Debugger::GetExceptionPauseInfo() {
+Dart_ExceptionPauseInfo Debugger::GetExceptionPauseInfo() const {
return exc_pause_info_;
}
« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698