Allow setting break-on-exceptions option over the service protocol.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 2602 matching lines @@
   // Construct the isolate list.
   {
     JSONArray jsarr(&jsobj, "isolates");
     ServiceIsolateVisitor visitor(&jsarr);
     Isolate::VisitIsolates(&visitor);
   }
   return true;
 }
 
 
+static const MethodParameter* get_debugger_update_params[] = {
+  ISOLATE_PARAMETER,
+  NULL,
+};
+
+
+static bool GetDebuggerUpdate(Isolate* isolate, JSONStream* js) {
+  if (Service::NeedsDebugEvents()) {
+    ServiceEvent event(isolate, ServiceEvent::kDebuggerUpdate);
+    Service::HandleEvent(&event);
+  }
+  PrintSuccess(js);
+  return true;
+}
+
+
+static const MethodParameter* set_exception_pause_info_params[] = {
+  ISOLATE_PARAMETER,
+  NULL,
+};
+
+
+static bool SetExceptionPauseInfo(Isolate* isolate, JSONStream* js) {
+  const char* exceptions = js->LookupParam("exceptions");
+  if (exceptions == NULL) {
+    PrintMissingParamError(js, "exceptions");
+    return true;
+  }
+
+  Dart_ExceptionPauseInfo info = kNoPauseOnExceptions;
+  if (strcmp(exceptions, "none") == 0) {
+    info = kNoPauseOnExceptions;
+  } else if (strcmp(exceptions, "all") == 0) {
+    info = kPauseOnAllExceptions;
+  } else if (strcmp(exceptions, "unhandled") == 0) {
+    info = kPauseOnUnhandledExceptions;
+  } else {
+    JSONObject jsobj(js);
+    jsobj.AddProperty("type", "Error");
+    jsobj.AddProperty("message", "illegal value for parameter 'exceptions'");
+    return true;
+  }
+
+  isolate->debugger()->SetExceptionPauseInfo(info);
+  if (Service::NeedsDebugEvents()) {
+    ServiceEvent event(isolate, ServiceEvent::kDebuggerUpdate);
+    Service::HandleEvent(&event);
+  }
+  PrintSuccess(js);
+  return true;
+}
+
+
 static const MethodParameter* get_flag_list_params[] = {
   NO_ISOLATE_PARAMETER,
   NULL,
 };
 
 
 static bool GetFlagList(Isolate* isolate, JSONStream* js) {
   Flags::PrintJSON(js);
   return true;
 }
@@ skipping 98 matching lines @@
   { "_getAllocationProfile", GetAllocationProfile,
     get_allocation_profile_params },
   { "_getCallSiteData", GetCallSiteData,
     get_call_site_data_params },
   { "getClassList", GetClassList,
     get_class_list_params },
   { "_getCoverage", GetCoverage,
     get_coverage_params },
   { "_getCpuProfile", GetCpuProfile,
     get_cpu_profile_params },
+  { "_getDebuggerUpdate", GetDebuggerUpdate,

[Cutch, 2015/06/12 13:10:47]

What about including the debugger settings in stackTrace and getting rid of this
RPC?

[rmacnak, 2015/06/15 17:53:51]

Seems okay. A debugger will generally fetch the stack to get started anyway.

+    get_debugger_update_params },
   { "getFlagList", GetFlagList ,
     get_flag_list_params },
   { "_getHeapMap", GetHeapMap,
     get_heap_map_params },
   { "_getInboundReferences", GetInboundReferences,
     get_inbound_references_params },
   { "_getInstances", GetInstances,
     get_instances_params },
   { "getIsolate", GetIsolate,
     get_isolate_params },
@@ skipping 24 matching lines @@
   { "_getVMMetricList", GetVMMetricList,
     get_vm_metric_list_params },
   { "pause", Pause,
     pause_params },
   { "removeBreakpoint", RemoveBreakpoint,
     remove_breakpoint_params },
   { "resume", Resume,
     resume_params },
   { "_requestHeapSnapshot", RequestHeapSnapshot,
     request_heap_snapshot_params },
+  { "_setExceptionPauseInfo", SetExceptionPauseInfo,
+    set_exception_pause_info_params },
   { "_setFlag", SetFlag,
     set_flags_params },
   { "setLibraryDebuggable", SetLibraryDebuggable,
     set_library_debuggable_params },
   { "setName", SetName,
     set_name_params },
 };
 
 
 ServiceMethodDescriptor* FindMethod(const char* method_name) {
   intptr_t num_methods = sizeof(service_methods_) /
                          sizeof(service_methods_[0]);
   for (intptr_t i = 0; i < num_methods; i++) {
     ServiceMethodDescriptor& method = service_methods_[i];
     if (strcmp(method_name, method.name) == 0) {
       return &method;
     }
   }
   return NULL;
 }
 
 
 }  // namespace dart