Allow setting break-on-exceptions option over the service protocol.

runtime/observatory/lib/src/service/object.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 /// An RpcException represents an exceptional event that happened
 /// while invoking an rpc.
 abstract class RpcException implements Exception {
   RpcException(this.message);
@@ skipping 1152 matching lines @@
       case ServiceEvent.kInspect:
         // Handled elsewhere.
         break;
 
       case ServiceEvent.kBreakpointAdded:
         _addBreakpoint(event.breakpoint);
         break;
 
       case ServiceEvent.kIsolateUpdate:
       case ServiceEvent.kBreakpointResolved:
+      case ServiceEvent.kDebuggerUpdate:
         // Update occurs as side-effect of caching.
         break;
 
       case ServiceEvent.kBreakpointRemoved:
         _removeBreakpoint(event.breakpoint);
         break;
 
       case ServiceEvent.kPauseStart:
       case ServiceEvent.kPauseExit:
       case ServiceEvent.kPauseBreakpoint:
@@ skipping 75 matching lines @@
   }
 
   Future stepOut() {
     return invokeRpc('resume', {'step': 'Out'});
   }
 
   Future setName(String newName) {
     return invokeRpc('setName', {'name': newName});
   }
 
+  Future getDebuggerUpdate() {
+    return invokeRpc('_getDebuggerUpdate', {});
+  }
+
+  Future setExceptionPauseInfo(String exceptions) {
+    return invokeRpc('_setExceptionPauseInfo', {'exceptions': exceptions});
+  }
+
   Future<ServiceMap> getStack() {
     return invokeRpc('getStack', {});
   }
 
   Future<ServiceObject> _eval(ServiceObject target,
                               String expression) {
     Map params = {
       'targetId': target.id,
       'expression': expression,
     };
@@ skipping 185 matching lines @@
   static const kPauseBreakpoint    = 'PauseBreakpoint';
   static const kPauseInterrupted   = 'PauseInterrupted';
   static const kPauseException     = 'PauseException';
   static const kResume             = 'Resume';
   static const kBreakpointAdded    = 'BreakpointAdded';
   static const kBreakpointResolved = 'BreakpointResolved';
   static const kBreakpointRemoved  = 'BreakpointRemoved';
   static const kGraph              = '_Graph';
   static const kGC                 = 'GC';
   static const kInspect            = 'Inspect';
+  static const kDebuggerUpdate     = '_DebuggerUpdate';
   static const kConnectionClosed   = 'ConnectionClosed';
 
   ServiceEvent._empty(ServiceObjectOwner owner) : super._empty(owner);
 
   ServiceEvent.connectionClosed(this.reason) : super._empty(null) {
     kind = kConnectionClosed;
   }
 
   @observable String kind;
   @observable Breakpoint breakpoint;
   @observable Frame topFrame;
-  @observable ServiceMap exception;
+  @observable Instance exception;
   @observable ServiceObject inspectee;
   @observable ByteData data;
   @observable int count;
   @observable String reason;
+  @observable String exceptions;
   int chunkIndex, chunkCount, nodeCount;
 
   @observable bool get isPauseEvent {
     return (kind == kPauseStart ||
             kind == kPauseExit ||
             kind == kPauseBreakpoint ||
             kind == kPauseInterrupted ||
             kind == kPauseException);
   }
 
@@ skipping 31 matching lines @@
     }
     if (map['chunkCount'] != null) {
       chunkCount = map['chunkCount'];
     }
     if (map['nodeCount'] != null) {
       nodeCount = map['nodeCount'];
     }
     if (map['count'] != null) {
       count = map['count'];
     }
+    if (map['_exceptions'] != null) {
+      exceptions = map['_exceptions'];
+    }
   }
 
   String toString() {
     if (data == null) {
       return "ServiceEvent(owner='${owner.id}', kind='${kind}')";
     } else {
       return "ServiceEvent(owner='${owner.id}', kind='${kind}', "
           "data.lengthInBytes=${data.lengthInBytes})";
     }
   }
@@ skipping 534 matching lines @@
   @observable Code unoptimizedCode;
   @observable bool isOptimizable;
   @observable bool isInlinable;
   @observable FunctionKind kind;
   @observable int deoptimizations;
   @observable String qualifiedName;
   @observable int usageCounter;
   @observable bool isDart;
   @observable ProfileFunction profile;
 
-  bool get canCache => true;
+  bool get canCache => !_id.startsWith(ServiceMap.objectIdRingPrefix);
   bool get immutable => false;
 
   ServiceFunction._empty(ServiceObject owner) : super._empty(owner);
 
   void _update(ObservableMap map, bool mapIsRef) {
     name = map['name'];
     vmName = (map.containsKey('vmName') ? map['vmName'] : name);
 
     _upgradeCollection(map, isolate);
 
@@ skipping 232 matching lines @@
   Set<CallSite> callSites = new Set<CallSite>();
   final lines = new ObservableList<ScriptLine>();
   final _hits = new Map<int, int>();
   @observable String uri;
   @observable String kind;
   @observable int firstTokenPos;
   @observable int lastTokenPos;
   @observable int lineOffset;
   @observable int columnOffset;
   @observable Library library;
-  bool get canCache => true;
+
+  bool get canCache => !_id.startsWith(ServiceMap.objectIdRingPrefix);

[Cutch, 2015/06/12 13:10:47]

A better way to fix handle this:

Whenever an "id" is fixed (and can be cached) there is a "fixedId" bit sent:

AddProperty("fixedId", true);

I never hooked it up on the Dart side. The correct fix is use this field in the
service library

_canCache = map['fixedId'] == true;
bool get canCache => _canCache;

[rmacnak, 2015/06/15 17:53:51]

Done.

   bool get immutable => true;
 
   String _shortUri;
 
   Script._empty(ServiceObjectOwner owner) : super._empty(owner);
 
   ScriptLine getLine(int line) {
     assert(_loaded);
     assert(line >= 1);
     return lines[line - lineOffset - 1];
@@ skipping 889 matching lines @@
   void _update(ObservableMap map, bool mapIsRef) {
     assert(!mapIsRef);
     _loaded = true;
     _upgradeCollection(map, owner);
     this.index = map['index'];
     this.function = map['function'];
     this.location = map['location'];
     this.code = map['code'];
     this.variables = map['vars'];
   }
+
+  String toString() => "Frame(${function.qualifiedName})";
 }
 
 
 class ServiceMessage extends ServiceObject {
   @observable int index;
   @observable String messageObjectId;
   @observable int size;
   @observable ServiceFunction handler;
   @observable SourceLocation location;
 
@@ skipping 52 matching lines @@
     var v = list[i];
     if ((v is ObservableMap) && _isServiceMap(v)) {
       list[i] = owner.getFromMap(v);
     } else if (v is ObservableList) {
       _upgradeObservableList(v, owner);
     } else if (v is ObservableMap) {
       _upgradeObservableMap(v, owner);
     }
   }
 }