Disable the embedded search field trials for users with themes.

Disable the embedded search field trials for users with themes.

Also allow InstantExtended field trial groups to override this behavior and set espv values as they see fit, to provide for flexibility for future experiments.

BUG=168298
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175660

[David Black, 2013-01-04 03:28:39]

Ready for review.

[dhollowa, 2013-01-04 17:11:49]

LGTM.

https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
File chrome/browser/ui/search/search.cc (right):

https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
chrome/browser/ui/search/search.cc:25: // Field trials should be named things
like "Group7 espv:2 themes:0" -
nit: period "." at end of sentence, not "-".

https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
File chrome/browser/ui/search/search_unittest.cc (right):

https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
chrome/browser/ui/search/search_unittest.cc:12: chrome::search::FieldTrialFlags
flags;
nit: Omit the chrome::search:: prefix here and throughout.  It is implicit while
within the namespace.

[David Black, 2013-01-04 19:55:32]

https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
File chrome/browser/ui/search/search.cc (right):

https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
chrome/browser/ui/search/search.cc:25: // Field trials should be named things
like "Group7 espv:2 themes:0" -
On 2013/01/04 17:11:49, dhollowa wrote:
> nit: period "." at end of sentence, not "-".

Done.

https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
File chrome/browser/ui/search/search_unittest.cc (right):

https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
chrome/browser/ui/search/search_unittest.cc:12: chrome::search::FieldTrialFlags
flags;
On 2013/01/04 17:11:49, dhollowa wrote:
> nit: Omit the chrome::search:: prefix here and throughout.  It is implicit
while
> within the namespace.

Done.

[David Black, 2013-01-04 21:17:35]

Attempting to submit.  TBR sky for the gypi file.

On 2013/01/04 19:55:32, David Black wrote:
>
https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
> File chrome/browser/ui/search/search.cc (right):
> 
>
https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
> chrome/browser/ui/search/search.cc:25: // Field trials should be named things
> like "Group7 espv:2 themes:0" -
> On 2013/01/04 17:11:49, dhollowa wrote:
> > nit: period "." at end of sentence, not "-".
> 
> Done.
> 
>
https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
> File chrome/browser/ui/search/search_unittest.cc (right):
> 
>
https://codereview.chromium.org/11743035/diff/1/chrome/browser/ui/search/sear...
> chrome/browser/ui/search/search_unittest.cc:12:
chrome::search::FieldTrialFlags
> flags;
> On 2013/01/04 17:11:49, dhollowa wrote:
> > nit: Omit the chrome::search:: prefix here and throughout.  It is implicit
> while
> > within the namespace.
> 
> Done.

[commit-bot: I haz the power, 2013-01-04 21:17:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-04 21:47:01]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-04 22:54:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-04 23:23:06]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-04 23:47:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-05 00:22:43]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-05 00:33:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-05 00:57:06]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-05 01:25:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-05 01:45:45]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-05 03:14:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-05 03:32:31]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-05 05:34:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-05 05:48:50]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-05 17:38:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-05 17:49:00]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 00:39:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/5001

[commit-bot: I haz the power, 2013-01-07 00:48:37]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 01:23:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/10009

[commit-bot: I haz the power, 2013-01-07 01:38:17]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 08:39:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/10009

[commit-bot: I haz the power, 2013-01-07 08:49:16]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 17:08:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/10009

[commit-bot: I haz the power, 2013-01-07 17:30:26]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[dhollowa, 2013-01-07 17:57:24]

https://codereview.chromium.org/11743035/diff/10009/chrome/chrome_tests_unit....
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/11743035/diff/10009/chrome/chrome_tests_unit....
chrome/chrome_tests_unit.gypi:2117:
'browser/ui/search/search_delegate_unittest.cc',
You'll need to add the new unittest file here as well to exclude it from the
android build.

[dhollowa, 2013-01-07 18:00:05]

https://codereview.chromium.org/11743035/diff/10009/chrome/browser/ui/search/...
File chrome/browser/ui/search/search.cc (right):

https://codereview.chromium.org/11743035/diff/10009/chrome/browser/ui/search/...
chrome/browser/ui/search/search.cc:96: return
GetUInt64ValueForFlagWithDefault(flag, default_value ? 1 : 0, flags);
Windows is complaining about type conversion.  Could use a !! here.

[David Black, 2013-01-07 19:05:19]

https://codereview.chromium.org/11743035/diff/10009/chrome/browser/ui/search/...
File chrome/browser/ui/search/search.cc (right):

https://codereview.chromium.org/11743035/diff/10009/chrome/browser/ui/search/...
chrome/browser/ui/search/search.cc:96: return
GetUInt64ValueForFlagWithDefault(flag, default_value ? 1 : 0, flags);
On 2013/01/07 18:00:05, dhollowa wrote:
> Windows is complaining about type conversion.  Could use a !! here.

Done.

https://codereview.chromium.org/11743035/diff/10009/chrome/chrome_tests_unit....
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/11743035/diff/10009/chrome/chrome_tests_unit....
chrome/chrome_tests_unit.gypi:2117:
'browser/ui/search/search_delegate_unittest.cc',
On 2013/01/07 17:57:24, dhollowa wrote:
> You'll need to add the new unittest file here as well to exclude it from the
> android build.

Done.

[commit-bot: I haz the power, 2013-01-07 19:07:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/9005

[commit-bot: I haz the power, 2013-01-07 19:43:41]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[David Black, 2013-01-07 20:03:56]

Looks like the Android build doesn't include any theme stuff.  Tentatively added
some #if #endif stuff to make it work.  PTAL.

[dhollowa, 2013-01-07 21:19:30]

lgtm

[commit-bot: I haz the power, 2013-01-07 21:30:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/25002

[commit-bot: I haz the power, 2013-01-08 00:00:05]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-08 01:11:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/11743035/25002

[dhollowa, 2013-01-09 01:50:10]

On 2013/01/08 01:11:43, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/dcblack%40chromium.org/11743035/25002

I landed this manually.