Add history popup when long pressing on the back key.

chrome/browser/ui/android/navigation_popup.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/android/navigation_popup.h"
+
+#include "base/android/jni_string.h"
+#include "base/android/scoped_java_ref.h"
+#include "base/bind.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/favicon/favicon_service.h"
+#include "chrome/browser/favicon/favicon_service_factory.h"
+#include "chrome/browser/history/history_types.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "googleurl/src/gurl.h"
+#include "grit/ui_resources.h"
+#include "jni/NavigationPopup_jni.h"
+#include "third_party/skia/include/core/SkBitmap.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/android/java_bitmap.h"
+#include "ui/gfx/favicon_size.h"
+#include "ui/gfx/image/image.h"
+
+using base::android::ScopedJavaLocalRef;
+
+NavigationPopup::NavigationPopup(JNIEnv* env, jobject obj)
+    : weak_jobject_(env, obj) {
+}
+
+NavigationPopup::~NavigationPopup() {
+}
+
+void NavigationPopup::Destroy(JNIEnv* env, jobject obj) {
+  delete this;
+}
+
+void NavigationPopup::FetchFaviconForUrl(JNIEnv* env,
+                                         jobject obj,
+                                         jstring jurl) {
+  Profile* profile = g_browser_process->profile_manager()->GetLastUsedProfile();
+  FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(
+      profile, Profile::EXPLICIT_ACCESS);
+  if (!favicon_service)
+    return;
+  GURL url = GURL(base::android::ConvertJavaStringToUTF16(env, jurl));
+  favicon_service->GetFaviconImageForURL(
+      FaviconService::FaviconForURLParams(profile,
+                                          url,
+                                          history::FAVICON,
+                                          gfx::kFaviconSize),
+      base::Bind(&NavigationPopup::OnFaviconDataAvailable,
+                 base::Unretained(this),
+                 url),
+      &cancelable_task_tracker_);
+}
+
+void NavigationPopup::OnFaviconDataAvailable(
+    GURL navigation_entry_url,
+    const history::FaviconImageResult& image_result) {
+  gfx::Image image = image_result.image;
+  if (image.IsEmpty()) {
+    ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+    image = rb.GetImageNamed(IDR_DEFAULT_FAVICON);
+  }
+
+  JNIEnv* env = base::android::AttachCurrentThread();
+  ScopedJavaLocalRef<jobject> obj = weak_jobject_.get(env);
+  if (!obj.obj())
+    return;
+
+  ScopedJavaLocalRef<jstring> jurl =

[David Trainor- moved to gerrit, 2013/01/03 18:57:31]

For things like this use jurl(base::android::ConvertUTF8ToJavaString(...)); if
you can as it saves running the default constructor followed by the =operator
instead of just the copy constructor (or so I was told a long time ago).

Not sure if this class supports it but worth a shot.

[Ted C, 2013/01/03 19:56:41]

Done.  Updated everywhere that I saw.

+      base::android::ConvertUTF8ToJavaString(env, navigation_entry_url.spec());
+
+  Java_NavigationPopup_onFaviconUpdated(
+      env,
+      obj.obj(),
+      jurl.obj(),
+      gfx::ConvertToJavaBitmap(image.ToSkBitmap()).obj());
+}
+
+static jint Init(JNIEnv* env, jobject obj) {
+  NavigationPopup* popup = new NavigationPopup(env, obj);
+  return reinterpret_cast<jint>(popup);
+}
+
+// static
+bool NavigationPopup::RegisterNavigationPopup(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}