Clean up: Use scoped_ptr<Foo[]> instead of scoped_array<Foo> in PortableDeviceWatcherWin::Enumerate…

Clean up: Use scoped_ptr<Foo[]> instead of scoped_array<Foo> in PortableDeviceWatcherWin::EnumerateAttachedDevice() and also free the associated memory by calling CoTaskMemFree function.

BUG=none
TEST=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175071

[kmadhusu, 2013-01-03 00:25:52]

cpu@: I have added you as a reviewer to review the windows specific code. PTAL.

Thanks.

https://codereview.chromium.org/11743008/diff/1/chrome/browser/system_monitor...
File chrome/browser/system_monitor/portable_device_watcher_win.cc (right):

https://codereview.chromium.org/11743008/diff/1/chrome/browser/system_monitor...
chrome/browser/system_monitor/portable_device_watcher_win.cc:423:
CoTaskMemFree(pnp_device_ids[index]);
As per
http://msdn.microsoft.com/en-us/library/windows/desktop/dd388693(v=vs.85).aspx,
I am supposed to free the associated memory using CoTaskMemFree() function.

[cpu_(ooo_6.6-7.5), 2013-01-03 21:01:21]

lgtm

[kmadhusu, 2013-01-03 21:09:36]

thestig: Can you do the OWNER's check?

Thanks.

[Lei Zhang, 2013-01-03 21:15:26]

https://codereview.chromium.org/11743008/diff/1/chrome/browser/system_monitor...
File chrome/browser/system_monitor/portable_device_watcher_win.cc (right):

https://codereview.chromium.org/11743008/diff/1/chrome/browser/system_monitor...
chrome/browser/system_monitor/portable_device_watcher_win.cc:423:
CoTaskMemFree(pnp_device_ids[index]);
On 2013/01/03 00:25:52, kmadhusu wrote:
> As per
>
http://msdn.microsoft.com/en-us/library/windows/desktop/dd388693%28v=vs.85%29...,
> I am supposed to free the associated memory using CoTaskMemFree() function.

Why not just do this at the end of the loop right above?

[kmadhusu, 2013-01-03 21:36:21]

thestig@: Addressed review comment. PTAL.

Thanks.

https://codereview.chromium.org/11743008/diff/1/chrome/browser/system_monitor...
File chrome/browser/system_monitor/portable_device_watcher_win.cc (right):

https://codereview.chromium.org/11743008/diff/1/chrome/browser/system_monitor...
chrome/browser/system_monitor/portable_device_watcher_win.cc:423:
CoTaskMemFree(pnp_device_ids[index]);
On 2013/01/03 21:15:26, Lei Zhang wrote:
> On 2013/01/03 00:25:52, kmadhusu wrote:
> > As per
> >
>
http://msdn.microsoft.com/en-us/library/windows/desktop/dd388693%2528v=vs.85%...,
> > I am supposed to free the associated memory using CoTaskMemFree() function.
> 
> Why not just do this at the end of the loop right above?

Done.

[Lei Zhang, 2013-01-03 21:40:18]

lgtm

[commit-bot: I haz the power, 2013-01-03 21:48:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/11743008/7001

[commit-bot: I haz the power, 2013-01-04 01:22:32]

Change committed as 175071