Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1174293006: DevTools: Add responsiveness strip to the timeline overview. (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
caseq, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Add responsiveness strip to the timeline overview. + Add horizontal guides to fps and utilization strips + Adjust strip heights BUG=497031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197272

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressing comments. #

Patch Set 3 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -14 lines) Patch
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 2 8 chunks +73 lines, -11 lines 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alph
4 years, 10 months ago (2015-06-17 12:44:58 UTC) #2
caseq
https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode89 Source/devtools/front_end/timeline/TimelineEventOverview.js:89: if (Runtime.experiments.isEnabled("frameRateOnEventsOverview")) { nit: nuke { } https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode101 Source/devtools/front_end/timeline/TimelineEventOverview.js:101: ...
4 years, 10 months ago (2015-06-17 12:56:13 UTC) #3
alph
https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode89 Source/devtools/front_end/timeline/TimelineEventOverview.js:89: if (Runtime.experiments.isEnabled("frameRateOnEventsOverview")) { On 2015/06/17 12:56:13, caseq wrote: > ...
4 years, 10 months ago (2015-06-17 13:22:01 UTC) #4
yurys
lgtm
4 years, 10 months ago (2015-06-17 16:27:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174293006/40001
4 years, 10 months ago (2015-06-17 16:53:56 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 19:26:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197272

Powered by Google App Engine
This is Rietveld 408576698