DevTools: Add responsiveness strip to the timeline overview.

DevTools: Add responsiveness strip to the timeline overview.

+ Add horizontal guides to fps and utilization strips
+ Adjust strip heights

BUG=497031
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197272

[alph, 2015-06-17 12:44:57]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org, yurys@chromium.org

[caseq, 2015-06-17 12:56:13]

https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineEventOverview.js (right):

https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:89: if
(Runtime.experiments.isEnabled("frameRateOnEventsOverview")) {
nit: nuke { }

https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:101: position +=
this._drawResponsivenessStrip(position,
WebInspector.TimelineEventOverview._smallStripHeight);
Does the height of drawn strip ever vary?

https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:102: position +=
this._drawFrames(position, fpsStripHeight);
ditto.

[alph, 2015-06-17 13:22:01]

https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineEventOverview.js (right):

https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:89: if
(Runtime.experiments.isEnabled("frameRateOnEventsOverview")) {
On 2015/06/17 12:56:13, caseq wrote:
> nit: nuke { }

Done.

https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:101: position +=
this._drawResponsivenessStrip(position,
WebInspector.TimelineEventOverview._smallStripHeight);
On 2015/06/17 12:56:12, caseq wrote:
> Does the height of drawn strip ever vary?

No, but this way the call site code is simpler. So I'd like to keep it this way
unless you object.

https://codereview.chromium.org/1174293006/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineEventOverview.js:102: position +=
this._drawFrames(position, fpsStripHeight);
On 2015/06/17 12:56:13, caseq wrote:
> ditto.

ditto.

[yurys, 2015-06-17 16:27:28]

lgtm

[alph, 2015-06-17 16:53:24]

The CQ bit was checked by alph@chromium.org

[alph, 2015-06-17 16:53:25]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/1174293006/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2015-06-17 16:53:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174293006/40001

[commit-bot: I haz the power, 2015-06-17 19:26:14]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197272